Skip to content

net-snmp: fix logging #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ckorber wants to merge 1 commit into from
Closed

net-snmp: fix logging #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions net/net-snmp/files/snmpd.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,10 @@ config snmpd general
# list network 'wan'
#
#config logging
# option log_file '0'
# option log_file_path '/var/log/snmpd.log'
# option log_file_priority 'info'
# option log_file '/var/log/snmpd.log'
# option log_file_priority 'i'
# option log_syslog '0'
# option log_syslog_facility 'daemon'
# option log_syslog_priority 'info'
# option log_syslog_facility 'd'
#
#config v3
# option username 'John'
Expand Down
19 changes: 10 additions & 9 deletions net/net-snmp/files/snmpd.init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,9 +350,7 @@ snmpd_configure_logging() {
local cfg="$1"
local log_syslog
local log_syslog_facility
local log_syslog_priority
local log_file
local log_file_path
local log_file_priority

config_get_bool log_syslog "$cfg" log_syslog 0
Expand All @@ -372,18 +370,21 @@ snmpd_configure_logging() {

if [ $log_syslog -eq 1 ]; then
config_get log_syslog_facility "$cfg" log_syslog_facility "d"
config_get log_syslog_priority "$cfg" log_syslog_priority "i"

procd_append_param command "-LS ${log_syslog_priority} ${log_syslog_facility}"
procd_append_param command -Ls "${log_syslog_facility}"
fi

config_get log_file_path "$cfg" log_file_path
config_get log_file "$cfg" log_file

if [ -n "$log_file_path" ]; then
if [ -n "$log_file" ]; then
config_get log_file_priority "$cfg" log_file_priority "i"

mkdir -p "$(dirname "${log_file_path}")"
procd_append_param command "-LF ${log_file_priority} ${log_file_path}"
mkdir -p "$(dirname "${log_file}")"
procd_append_param command -LF "${log_file_priority} ${log_file}"
fi

if [ "$log_syslog" -eq 0 ] && [ -z "$log_file" ]; then
procd_append_param command -Lf /dev/null
fi
}

Expand Down Expand Up @@ -425,10 +426,10 @@ start_service() {
append_parm v1trapaddress host v1trapaddress
append_parm trapsess trapsess trapsess
config_foreach snmpd_snmpv3_add v3 general
config_foreach snmpd_configure_logging log

procd_set_param command $PROG -f -r -p "$pid_file"
procd_append_param command -C -c "$CONFIGFILE"
config_foreach snmpd_configure_logging log
procd_set_param respawn

for iface in $(ls /sys/class/net 2>/dev/null); do
Expand Down
Loading