Api 연동 + 다른 브랜치 merge PR (@kaydee , @sigmaith)#17
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR integrates multiple branches to deliver comprehensive API connectivity, authentication system improvements, and extensive UI/UX enhancements.
Changes:
- Backend API integration for projects, articles, news, chat, admin features, and authentication
- Token-based authentication with automatic refresh mechanism using cookies
- UI/UX improvements including new search modals, filter bars, title banners, and category filters
Reviewed changes
Copilot reviewed 83 out of 125 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/context/AuthContext.tsx | Simplified authentication with automatic token refresh via fetchWithRefresh |
| src/components/layout/* | New reusable UI components (TitleBanner, SearchModal, ContentFilterBar, CategoryFilter) |
| src/app/api/* | New API routes for projects, news, articles, chat, and user management |
| src/app/admin/* | Admin dashboard with real-time data from backend APIs |
| src/app/(main)/topics/LearningTopics.tsx | Dynamic category-based content loading from backend |
| package.json | Added socket.io-client dependency for real-time chat |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| typeof tag === 'string' | ||
| ? tag.toLowerCase().includes(query) | ||
| : tag.name?.toLowerCase().includes(query) |
There was a problem hiding this comment.
Consider extracting the tag matching logic into a helper function to improve readability and reduce code duplication across articles, projects, and topics filtering.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
| setLoadingProjects(true); | ||
| try { | ||
| const projectParams = new URLSearchParams(); | ||
| projectParams.append('categories', currentCategory.name); // API는 한글 카테고리 이름을 받음 |
There was a problem hiding this comment.
The comment states the API accepts Korean category names, but this should be verified as consistent with the API specification. If the API format changes, this could cause integration issues.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
use toast Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@kaydeeloka I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you. |
feat: update image with fallback for article and project
#️⃣ 이슈
관련된 PR링크입니다.
@sigmaith [PR링크]
@kaydeeloka [PR링크]
🔎 작업 내용
@kaydeeloka PR 내용
1) UI/UX 개선
@PlusUltraCode PR내용
2) 프로젝트 기능 / API 연동
3) 아티클 기능 / API 연동
4) 뉴스 기능 / API 연동
5) 메인 / 토픽 API 연동
6) 알람 기능
7) 어드민 / 회원관리 / 권한
UserRoleenum을 백엔드 API 기준으로 통합admin/members하드코딩 제거8) 마이페이지 기능
9) 실시간 채팅
10) 통합 / 안정화
@sigmaith
11) 인증 / 토큰 체계 정비
fetchWithRefresh) 추가/api/auth/user중복 호출 제거12 ) AuthContext 정리
13) 멤버 조회 페이지 api 연동
🤔 고민해볼 부분 & 코드 리뷰 희망사항
중요!!!!!
3개의 pr을 머지하는 작업이라 각자가 개발한 부분이 적용이 안되는 문제가 생길 수 있을거 같아요!!
반드시 확인 부탁합니다 ㅠㅠ,,, ;;;
🧲 참고 자료 및 공유 사항