Skip to content

Rename and clean up files.#21

Open
devinamatthews wants to merge 2 commits intomainfrom
rename-files
Open

Rename and clean up files.#21
devinamatthews wants to merge 2 commits intomainfrom
rename-files

Conversation

@devinamatthews
Copy link
Collaborator

  • Rename all header files with "tapp_" prefix. This will help prevent problems when users do something like #include "tapp_XXX.h" with -I/path/to/tapp/tapp.
  • Remove some old discussion and proposal files.

- Rename all header files with "tapp_" prefix. This will help prevent problems when users do something like `#include "tapp_XXX.h"` with `-I/path/to/tapp/tapp`.
- Remove some old discussion and proposal files.
Copy link
Contributor

@janbrandejs janbrandejs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be an efficient scheme which we could potentialy require anytime when the interface itself is changed in multiple places:

  1. there is a pull request on tapp interface itself
  2. reviewer thinks it's a good idea
  3. put the suggested changes on a branch in reference implentation
  4. test passed (pipeline test++?) -> you can merge in master there without a review
  5. the pull request to tapp itself can be approved

@devinamatthews
Copy link
Collaborator Author

Yes definitely any changes should go through CI and the ref. implementation is a good place for that. I need to make sure we are starting from 1:1 on the interface defined here and implemented in the reference.

@devinamatthews
Copy link
Collaborator Author

Just a couple more PRs here then I'll work on that flow :).

@devinamatthews
Copy link
Collaborator Author

Except, I'm not sure about steps 1 and 2 since that will be a lot more work for maintainers. Perhaps it would be good to keep development (including interface) on the reference implementation master branch and then group updates atomically into new versions of the official interface.

@janbrandejs
Copy link
Contributor

Excellent idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants