-
Notifications
You must be signed in to change notification settings - Fork 0
Task/digital rocks #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
taoteg
wants to merge
369
commits into
main
Choose a base branch
from
task/digital-rocks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Task/digital rocks #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes buttons that allow for modification of datasets for view-only members
- Added frontend util for making a publication request to the new endpoint - Added a publication request endpoint that accepts POST requests - Added flow for publication request which involves adding service account with correct permissions, creating a new review system, transferring files and metadata to the review system, and adding reviewers
- Showing loading indicators on drp form submissions - file preview only shows metadata for supported file types - added extra error handling
* updating all description mins and maxes * update to unify variable name between templates * adding help link to description in edit dataset modal * updating wording per feedback * updating edit dataset modal description test * modifying validation to be based on form info and not direct in the code --------- Co-authored-by: Shayan Khan <skhan@tacc.utexas.edu> Co-authored-by: shayanaijaz <shayanaijaz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
NOT FOR ACTUAL MERGE!
Used to cmpare branches to identify where DPMP extends Core-Portal.
Related
Changes
Testing
UI
Notes