Skip to content

Conversation

@nathanfranklin
Copy link
Member

Overview

Remove file input suffix for tapis file inputs

@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.05%. Comparing base (31468f1) to head (6b66d62).

Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           bug/WP-949--new-compress-bugs    #1112   +/-   ##
==============================================================
  Coverage                          61.05%   61.05%           
==============================================================
  Files                                211      211           
  Lines                               6316     6316           
  Branches                             742      742           
==============================================================
  Hits                                3856     3856           
  Misses                              2291     2291           
  Partials                             169      169           
Flag Coverage Δ
unittests 61.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the job history modal, the labels must be unique for each input for all inputs to be shown, otherwise they can get overwritten for the modal view:

Honestly not sure what to recommend, feels like the front-end logic to work around this result will get overly complex, especially if we expand the use of tapis' jobFileInputs object to more apps in the future.

@edmondsgarrett
Copy link
Contributor

Sorry, should say that in my testing, I do see that in a compress job with 3 inputs, I am only seeing two in the job history modal: the first in the list, and the third.

@nathanfranklin nathanfranklin marked this pull request as draft May 13, 2025 21:19
Base automatically changed from bug/WP-949--new-compress-bugs to main May 13, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants