-
Notifications
You must be signed in to change notification settings - Fork 0
hotfix: remove file input suffix for tapis file inputs #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
hotfix: remove file input suffix for tapis file inputs #1112
Conversation
… type + available compute time+ update test fixture
…ethod for hidden objects)
…Portal into bug/WP-949--new-compress-bugs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bug/WP-949--new-compress-bugs #1112 +/- ##
==============================================================
Coverage 61.05% 61.05%
==============================================================
Files 211 211
Lines 6316 6316
Branches 742 742
==============================================================
Hits 3856 3856
Misses 2291 2291
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…Portal into bug/WP-949--new-compress-bugs
…press-bugs--file-input-suffix
edmondsgarrett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the job history modal, the labels must be unique for each input for all inputs to be shown, otherwise they can get overwritten for the modal view:
| acc[item.label] = item.value; |
Honestly not sure what to recommend, feels like the front-end logic to work around this result will get overly complex, especially if we expand the use of tapis' jobFileInputs object to more apps in the future.
|
Sorry, should say that in my testing, I do see that in a compress job with 3 inputs, I am only seeing two in the job history modal: the first in the list, and the third. |
Overview
Remove file input suffix for tapis file inputs