Skip to content

fix double quotes#21

Open
ngajhede wants to merge 3 commits intoT3-Content:mainfrom
ngajhede:fix-double-quotes
Open

fix double quotes#21
ngajhede wants to merge 3 commits intoT3-Content:mainfrom
ngajhede:fix-double-quotes

Conversation

@ngajhede
Copy link

@ngajhede ngajhede commented Feb 23, 2026

closes #13

image

Summary by CodeRabbit

  • Bug Fixes
    • Improved response text processing to correctly handle smart quotes (curly quotation marks) in addition to standard quotation marks.

@coderabbitai
Copy link

coderabbitai bot commented Feb 23, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Modified the cleanResponse function in game.ts to strip smart quotes ("...") alongside existing double and single quote handling. A blank line formatting adjustment was also made in runGame. No functional impact beyond enhanced quote character support.

Changes

Cohort / File(s) Summary
Quote handling enhancement
game.ts
Extended cleanResponse to remove smart quotes (" and ") in addition to standard double and single quotes. Minor formatting adjustment to runGame with no functional impact.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Smart quotes were causing strife,
Double-checking answers in the game of life,
But now our clever function sees them all,
And strips each quote, both big and small! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title "fix double quotes" accurately summarizes the main change in the PR, which broadens quote handling in cleanResponse to remove surrounding smart quotes in addition to existing quote types.
Linked Issues check ✅ Passed The PR directly addresses issue #13 by extending cleanResponse to unwrap smart quotes (“”) alongside existing double and single quotes, resolving the duplicate quote rendering problem described in the linked issue.
Out of Scope Changes check ✅ Passed The PR contains minimal scope: quote handling enhancement and a formatting whitespace change. Both changes are directly related to fixing issue #13, with no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@macroscopeapp
Copy link

macroscopeapp bot commented Feb 23, 2026

Strip curly double quotes in cleanResponse for input normalization in game.ts

Extend cleanResponse in game.ts to remove leading and trailing curly double quotes; minor whitespace edits in the game loop.

📍Where to Start

Start with the cleanResponse utility in game.ts.


Macroscope summarized ebf0d40.

@uriahn
Copy link

uriahn commented Feb 23, 2026

image Does this only remove quotes if they are at both the beginning and end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double quotes

2 participants