Add worlimit indicator for essays and quiz sites.#11
Closed
Menrath wants to merge 2 commits intoSysBind:mainfrom
Closed
Add worlimit indicator for essays and quiz sites.#11Menrath wants to merge 2 commits intoSysBind:mainfrom
Menrath wants to merge 2 commits intoSysBind:mainfrom
Conversation
btc989
reviewed
Apr 28, 2022
btc989
left a comment
btc989
left a comment
There was a problem hiding this comment.
I was pulling this into our version of wordcount. In wordlimit.php, get_wordlimits() I had to change the url comparison to:
strpos($PAGE->url->get_path(), '/mod/quiz/attempt.php')!== false (same for view.php)
This could be switched to regrex too. Our url paths were showing up differently so the exact comparison just was not working. Just thought I would leave the suggestion. Great work on this!
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a wordlimit indicator next to the wordcounter value, if the users edits some onlinetext with a supper/maximum wordlimit set.
As maxwordlimit for quiz sections have been introduced in Moodle 3.11 this PR breaks compatibility with older moodle versions.
Feedback welcome.