Add tests for total supply zero scenario#15
Open
bingen wants to merge 1 commit intoSynthetixio:masterfrom
Open
Add tests for total supply zero scenario#15bingen wants to merge 1 commit intoSynthetixio:masterfrom
bingen wants to merge 1 commit intoSynthetixio:masterfrom
Conversation
If total supply is zero during reward period, reward tokens corresponding to the time while that happens would be lost. It is a very unlikely scenario, and it has an easy workaround: the account providing the rewards can make sure that doesn’t happen by staking a tiny amount. But it’s better to be aware of it.
bingen
added a commit
to liquity/dev
that referenced
this pull request
Jan 27, 2021
See for reference: aragonone/liquidity-rewards#4 Synthetixio/Unipool#15 Now the time during which totalSupply is zero will be appended at the end of the rewards period, extending it. So the total time during which there have been some staked tokens will eventually be `DURATION`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If total supply is zero during reward period, reward tokens
corresponding to the time while that happens would be lost.
It is a very unlikely scenario, and it has an easy workaround: the
account providing the rewards can make sure that doesn’t happen by
staking a tiny amount. But it’s better to be aware of it.
I didn’t open an issue because it seems “Issues” tab is not enabled in your repo, but you can see it here: aragonone#4