FBXエクスポート時にfbxファイルに座標軸を書き出すように

[tomoki-suzuki-syn]

Unityで右手座標系でFBXを書き出す→Unityに読み込み時、FBXの座標軸方向の情報により正しい情報で読み込まれます

Summary by CodeRabbit

• 新機能

  • FBXエクスポート時のオプションに「座標系」の指定が追加されました。

• ドキュメント

  • ENUとESU間の座標変換に関するコメント表記を修正しました。
  • FBXの座標系設定に関する説明コメントを追加しました。

• リファクタ

  • FBXエクスポート時の座標系設定方法が変更され、シーンのグローバル設定に直接適用されるようになりました。

[coderabbitai]

Walkthrough

FBXエクスポート時の座標系設定方法が変更され、FBXシーンのグローバル設定に直接軸システムを適用するようになりました。また、C#のFbxWriteOptions構造体にCoordinateSystemフィールドが追加され、コメントの誤記修正も行われています。

Changes

ファイル・グループ	変更内容概要
src/geometry/geo_reference.cpp	ENU→ESU変換式に関するコメントの誤記を修正（ロジックの変更なし）
src/mesh_writer/fbx_writer.cpp	FBX軸システム設定方法をConvertSceneからグローバル設定への直接適用に変更、座標系オプションに応じた軸システム設定追加
wrappers/csharp/LibPLATEAU.NET/CSharpPLATEAU/MeshWriter/FbxWriter.cs	FbxWriteOptions構造体にCoordinateSystemフィールド追加、コンストラクタを新フィールド対応に変更
wrappers/csharp/LibPLATEAU.NET/CSharpPLATEAU.Test/MeshWriter/FbxWriterTest.cs	テストでFbxWriteOptionsの生成時に座標系パラメータを追加し、CoordinateSystem.ENUを指定

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FbxWriter
    participant FBXScene

    User->>FbxWriter: FbxWriteOptions(fileFormat, coordinateSystem)
    FbxWriter->>FBXScene: SetAxisSystem(axis_system)
    Note right of FBXScene: グローバル設定に軸システムを直接適用

Loading

Possibly related PRs

• FBXエクスポートの座標系バグ #277: FBXエクスポート時の座標系変換ロジックの削除や変換バグ修正など、FBX出力の座標系設定方法に関連。

Poem

うさぎの耳で軸を聞く、
FBXの世界も今や新しく、
右手でパリティOddに揃えたら、
UnityもUnrealもご機嫌だ。
新しい座標で跳ねる春、
コードの野原は今日も晴れ！
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db88486 and ff1ecbf.

📒 Files selected for processing (1)

• src/mesh_writer/fbx_writer.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/mesh_writer/fbx_writer.cpp

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: check-submodule-license
• GitHub Check: build-and-test (macos-14, arm64)
• GitHub Check: build-and-test (ubuntu-24.04, x86_64)
• GitHub Check: build-and-test (windows-2022, x86_64)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.