fix PIE compilation with TSan and remove codecov.yml#809
Merged
Rexicon226 merged 8 commits intomainfrom Jul 17, 2025
Merged
Conversation
Rexicon226
force-pushed
the
Rexicon226/codecov-fix
branch
3 times, most recently
from
27d46f1 to
6a76dac
Compare
Rexicon226
force-pushed
the
Rexicon226/codecov-fix
branch
from
d639ac7 to
7cd3fd2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dnut
approved these changes
Jul 17, 2025
InKryption
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you can see here, https://docs.codecov.com/docs/github-checks, CodeCov has deprecated its annotations feature. This PR removes the
codecov.ymlfile that was disabling it and bumps the orb version to one that outputs a config file that doesn't contain theannotationsfield, so that CodeCov interprets it as valid.