Open
Conversation
Codecov Report❌ Patch coverage is
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
hamza-syndica
force-pushed
the
rpc-gethealth
branch
from
82249e8 to
e074d49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
getHealthRPC methodImplements the getHealth JSON-RPC method that checks if the node is healthy by comparing the node's latest optimistically confirmed slot against the cluster's slot from gossip (analogous to RpcHealth::check (https://github.com/anza-xyz/agave/blob/master/rpc/src/rpc_health.rs#L44-L107))
Adds proper JSON-RPC error responses (code -32005) for unhealthy states, matching Agave's NodeUnhealthy error (https://github.com/anza-xyz/agave/blob/master/rpc-client-api/src/custom_error.rs#L149-L159)
Updates HTTP GET /health endpoint to return actual health status (ok, behind, unknown) instead of hardcoded unknown (matching rpc_service.rs (https://github.com/anza-xyz/agave/blob/master/rpc/src/rpc_service.rs#L332-L340))