removed accounts db v1 code by hamza-syndica · Pull Request #1235 · Syndica/sig

hamza-syndica · 2026-02-18T10:26:47Z

Remove AccountsDB v1, use only AccountsDB v2 (Two.zig)

Summary

Removes the legacy AccountsDB v1 implementation (~8,400 lines of code deleted)
Consolidates all account storage to use AccountsDB v2 (Two.zig) which uses SQLite for rooted storage
Updates all dependent code paths, tests, and documentation
Deleted Files (v1 code)
src/accountsdb/db.zig - Main v1 AccountsDB struct (5,060 lines)
src/accountsdb/index.zig - v1 account index implementation (705 lines)
src/accountsdb/manager.zig - v1 manager loop for flushing/shrinking/snapshots (1,736 lines)
src/accountsdb/swiss_map.zig - v1 high-performance hashmap (931 lines)

Key Changes

account_store.zig: Removed accounts_db union variant, now only uses accounts_db_two. Fixed slot 0 edge case in getLatest() and added zero-lamport account filtering
cmd.zig: Removed mock_rpc_server command (commented out with TODO for v2 support), removed createSnapshot command
benchmarks.zig: Removed v1 benchmarks, added new src/accountsdb/two/benchmarks.zig
fuzz.zig: Fuzzer rewritten to use v2 API
snapshot/data.zig: Moved helper functions (isZeroLamport, slotCountInBucket, pubkeyBinIndex) from deleted db.zig
Two.zig: Added constants migrated from v1 (DB_LOG_RATE, MERKLE_FANOUT, etc.)

Not Yet Implemented in v2

The following v1 features are not yet available in v2:

Snapshot generation (generateFullSnapshot, generateIncrementalSnapshot)
Geyser integration for streaming accounts from snapshots
mock_rpc_server command (requires loadWithDefaults and registerRPCHooks)

codecov · 2026-02-18T11:35:43Z

Codecov Report

❌ Patch coverage is 90.80460% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/accountsdb/account_store.zig	76.19%	5 Missing ⚠️
src/rpc/server/server.zig	91.66%	3 Missing ⚠️

Files with missing lines	Coverage Δ
src/accountsdb/snapshot/data.zig	`89.40% <100.00%> (-1.04%)`	⬇️
src/consensus/replay_tower.zig	`96.15% <100.00%> (+0.01%)`	⬆️
src/replay/freeze.zig	`97.04% <ø> (-0.49%)`	⬇️
src/runtime/account_loader.zig	`97.45% <100.00%> (-0.09%)`	⬇️
src/utils/tar.zig	`81.57% <ø> (ø)`
src/rpc/server/server.zig	`95.45% <91.66%> (-2.68%)`	⬇️
src/accountsdb/account_store.zig	`95.39% <76.19%> (-0.09%)`	⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/config.zig

src/accountsdb/two/Two.zig

Sobeston

Seems good, just a couple nits

src/config.zig

src/runtime/account_loader.zig

InKryption

A couple minor comments. Love too see the cruft dismantled.

InKryption · 2026-03-02T17:54:12Z

src/accountsdb/two/benchmarks.zig

+
+const Two = @import("Two.zig");
+const Rooted = @import("Rooted.zig");
+const Unrooted = @import("Unrooted.zig");


While I'm personally not hard-set on this, the generally established convention for sig is to import these kinds of things through qualified references, ie

Suggested change

const Unrooted = @import("Unrooted.zig");

const sig = @import("../../sig.zig");

const Two = sig.accounts_db.Two;

const Rooted = Two.Rooted;

const Unrooted = Two.Unrooted;

Given the brevity of Two.Rooted, could consider just removing those aliases as well - I leave that up to you

InKryption · 2026-03-02T17:55:17Z

src/accountsdb/two/benchmarks.zig

+        const random = prng.random();
+
+        // Generate random pubkeys
+        var pubkeys = try allocator.alloc(Pubkey, n_accounts);


Prefer const by default. No reason for this slice to be in a mutable variable.

InKryption · 2026-03-02T17:55:23Z

src/accountsdb/two/benchmarks.zig

+        }
+
+        // Generate random accounts
+        var accounts = try allocator.alloc(AccountSharedData, n_accounts);


InKryption · 2026-03-02T17:55:57Z

src/accountsdb/two/benchmarks.zig

+    const allocator = std.testing.allocator;
+    _ = allocator;


Why is this here?

InKryption · 2026-03-02T18:18:52Z

src/rpc/server/server.zig

+            const encoded_data: sig.rpc.methods.GetAccountInfo.Response.Value.Data =
+                switch (encoding) {
+                    .base64 => blk: {
+                        const encoded_len = std.base64.standard.Encoder.calcSize(raw_data.len);
+                        const encoded_buf = try alloc.alloc(u8, encoded_len);
+                        _ = std.base64.standard.Encoder.encode(encoded_buf, raw_data);
+                        break :blk .{ .encoded = .{ encoded_buf, .base64 } };
+                    },
+                    .base58 => return error.UnsupportedEncoding,
+                    .@"base64+zstd" => return error.UnsupportedEncoding,
+                    .jsonParsed => return error.UnsupportedEncoding,
+                };


Fwiw, in cases like these, I find a local alias can help:

Suggested change

const encoded_data: sig.rpc.methods.GetAccountInfo.Response.Value.Data =

switch (encoding) {

.base64 => blk: {

const encoded_len = std.base64.standard.Encoder.calcSize(raw_data.len);

const encoded_buf = try alloc.alloc(u8, encoded_len);

_ = std.base64.standard.Encoder.encode(encoded_buf, raw_data);

break :blk .{ .encoded = .{ encoded_buf, .base64 } };

},

.base58 => return error.UnsupportedEncoding,

.@"base64+zstd" => return error.UnsupportedEncoding,

.jsonParsed => return error.UnsupportedEncoding,

};

const GetAccountInfoResp = sig.rpc.methods.GetAccountInfo.Response;

const base64_encoder = std.base64.standard.Encoder;

const encoded_data: GetAccountInfoResp.Value.Data = switch (encoding) {

.base64 => blk: {

const encoded_len = base64_encoder.calcSize(raw_data.len);

const encoded_buf = try alloc.alloc(u8, encoded_len);

_ = base64_encoder.encode(encoded_buf, raw_data);

break :blk .{ .encoded = .{ encoded_buf, .base64 } };

},

.base58 => return error.UnsupportedEncoding,

.@"base64+zstd" => return error.UnsupportedEncoding,

.jsonParsed => return error.UnsupportedEncoding,

};

Note: base64_encoder.calcSize is not guaranteed to yield the exact size, only an upper bound. The exact-sized buffer is what is returned by encode, so maybe realloc the original encoded_buf so that's resized down to the concrete length before returning it.

github-project-automation bot added this to Sig Feb 18, 2026

github-project-automation bot moved this to 🏗 In progress in Sig Feb 18, 2026

Sobeston reviewed Feb 18, 2026

View reviewed changes

src/config.zig Outdated Show resolved Hide resolved

Sobeston reviewed Feb 18, 2026

View reviewed changes

src/config.zig Outdated Show resolved Hide resolved

Sobeston reviewed Feb 18, 2026

View reviewed changes

src/accountsdb/two/Two.zig Outdated Show resolved Hide resolved

hamza-syndica marked this pull request as ready for review February 18, 2026 17:15

hamza-syndica requested review from dnut, ultd and yewman as code owners February 18, 2026 17:15

hamza-syndica requested a review from Sobeston February 25, 2026 12:33

Sobeston requested changes Feb 25, 2026

View reviewed changes

src/config.zig Show resolved Hide resolved

src/runtime/account_loader.zig Show resolved Hide resolved

github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Feb 25, 2026

Sobeston previously approved these changes Feb 26, 2026

View reviewed changes

hamza72x added 7 commits February 27, 2026 00:20

removed accounts db v1 code

80c7a67

style fixes

a19dda8

generated docs

0c4286b

conformance fix

5949732

updated as per Sebastian comment

7002944

fix mess after merge

d7f01ab

addressed pr comments

a50cff4

hamza-syndica dismissed Sobeston’s stale review via a50cff4 February 26, 2026 18:21

hamza-syndica force-pushed the remove-accountsdb-v1 branch from ea02a7e to a50cff4 Compare February 26, 2026 18:21

Sobeston approved these changes Feb 27, 2026

View reviewed changes

InKryption reviewed Mar 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

removed accounts db v1 code#1235

removed accounts db v1 code#1235
hamza-syndica wants to merge 7 commits intomainfrom
remove-accountsdb-v1

hamza-syndica commented Feb 18, 2026

Uh oh!

codecov bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sobeston left a comment

Uh oh!

Uh oh!

Uh oh!

InKryption left a comment

Uh oh!

InKryption Mar 2, 2026

Uh oh!

InKryption Mar 2, 2026

Uh oh!

InKryption Mar 2, 2026

Uh oh!

InKryption Mar 2, 2026

Uh oh!

InKryption Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-const Unrooted = @import("Unrooted.zig");
+const sig = @import("../../sig.zig");
+const Two = sig.accounts_db.Two;
+const Rooted = Two.Rooted;
+const Unrooted = Two.Unrooted;

Conversation

hamza-syndica commented Feb 18, 2026

Summary

Key Changes

Not Yet Implemented in v2

Uh oh!

codecov bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sobeston left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

InKryption left a comment

Choose a reason for hiding this comment

Uh oh!

InKryption Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

InKryption Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

InKryption Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

InKryption Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

InKryption Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Feb 18, 2026 •

edited

Loading