feat(rpc): implement getBlock

conformance/src/txn_execute.zig

@@ -387,7 +387,7 @@ fn executeTxnContext(
                 .update_sysvar_deps = update_sysvar_deps,
             },
         );
-        try update_sysvar.updateClock(allocator, .{
+        _ = try update_sysvar.updateClock(allocator, .{
             .feature_set = &feature_set,
             .epoch_schedule = &epoch_schedule,
             .epoch_stakes = epoch_stakes_map.getPtr(epoch),
@@ -611,7 +611,7 @@ fn executeTxnContext(
                         .update_sysvar_deps = update_sysvar_deps,
                     },
                 );
-                try update_sysvar.updateClock(allocator, .{
+                _ = try update_sysvar.updateClock(allocator, .{
                     .feature_set = &feature_set,
                     .epoch_schedule = &epoch_schedule,
                     .epoch_stakes = epoch_stakes_map.getPtr(epoch),

src/cmd.zig

@@ -1675,6 +1675,11 @@ fn validator(
         .account_reader = account_store.reader(),
     });
 
+    try app_base.rpc_hooks.set(allocator, sig.rpc.hook_contexts.Ledger{
+        .ledger = &ledger,
+        .slot_tracker = &replay_service_state.replay_state.slot_tracker,
+    });
+
     const replay_thread = try replay_service_state.spawnService(
         &app_base,
         if (maybe_vote_sockets) |*vs| vs else null,

src/core/ReservedAccounts.zig

@@ -37,10 +37,19 @@ pub fn initForSlot(
     slot: Slot,
 ) Allocator.Error!ReservedAccounts {
     var reserved_accounts = try init(allocator);
+    errdefer reserved_accounts.deinit(allocator);
     reserved_accounts.update(feature_set, slot);
     return reserved_accounts;
 }
 
+pub fn initAllActivated(allocator: Allocator) Allocator.Error!ReservedAccounts {
+    var reserved_accounts = ReservedAccounts{ .map = .empty };
+    errdefer reserved_accounts.deinit(allocator);
+    try reserved_accounts.map.ensureTotalCapacity(allocator, ACCOUNTS.len);
+    for (ACCOUNTS) |account| reserved_accounts.map.putAssumeCapacity(account.pubkey, {});
+    return reserved_accounts;
+}
+
 pub fn update(
     self: *ReservedAccounts,
     feature_set: *const FeatureSet,
@@ -55,7 +64,7 @@ pub fn update(
     }
 }
 
-const ACCOUNTS: []const struct { pubkey: Pubkey, feature: ?Feature } = &.{
+const ACCOUNTS = [_]struct { pubkey: Pubkey, feature: ?Feature }{
     // zig fmt: off
     .{ .pubkey = sig.runtime.program.address_lookup_table.ID,  .feature = .add_new_reserved_account_keys },
     .{ .pubkey = sig.runtime.program.bpf_loader.v1.ID,         .feature = null },

src/core/features.zon

@@ -253,4 +253,5 @@
     .{ .name = "increase_cpi_account_info_limit", .pubkey = "H6iVbVaDZgDphcPbcZwc5LoznMPWQfnJ1AM7L1xzqvt5" },
     .{ .name = "vote_state_v4", .pubkey = "Gx4XFcrVMt4HUvPzTpTSVkdDVgcDSjKhDN1RqRS6KDuZ" },
     .{ .name = "enable_bls12_381_syscall", .pubkey = "b1sraWPVFdcUizB2LV5wQTeMuK8M313bi5bHjco5eVU" },
+    .{ .name = "remove_simple_vote_from_cost_model", .pubkey = "2GCrNXbzmt4xrwdcKS2RdsLzsgu4V5zHAemW57pcHT6a" },
 }

src/core/hash.zig

@@ -125,6 +125,10 @@ pub const Hash = extern struct {
         };
     }
 
+    pub fn jsonStringify(self: Hash, write_stream: anytype) !void {
+        try write_stream.write(self.base58String().constSlice());
+    }
+
     /// Intended to be used in tests.
     pub fn initRandom(random: std.Random) Hash {
         var data: [SIZE]u8 = undefined;

src/core/transaction.zig

@@ -419,9 +419,13 @@ pub const Message = struct {
     pub fn isWritable(
         self: Message,
         index: usize,
-        lookups: LookupTableAccounts,
+        maybe_lookups: ?LookupTableAccounts,
         reserved_accounts: *const ReservedAccounts,
     ) bool {
+        const lookups = maybe_lookups orelse LookupTableAccounts{
+            .writable = &.{},
+            .readonly = &.{},
+        };
         const pubkey = blk: {
             if (index < self.account_keys.len) {
                 if (index >= self.signature_count) {

src/ledger/Ledger.zig

@@ -1,4 +1,5 @@
 const std = @import("std");
+const builtin = @import("builtin");
 const sig = @import("../sig.zig");
 const lib = @import("lib.zig");
 
@@ -53,6 +54,21 @@ pub fn init(
     };
 }
 
+pub fn initForTest(
+    allocator: Allocator,
+) !struct { Ledger, std.testing.TmpDir } {
+    if (!builtin.is_test) @compileError("only used in tests");
+    var tmp = std.testing.tmpDir(.{});
+    try tmp.dir.makeDir("ledger");
+    const path = try tmp.dir.realpathAlloc(allocator, "ledger");
+    defer allocator.free(path);
+
+    return .{
+        try Ledger.init(allocator, .FOR_TESTS, path, null),
+        tmp,
+    };
+}
+
 pub fn reader(self: *Ledger) Reader {
     return .{
         .ledger = self,

src/ledger/Reader.zig

@@ -1519,7 +1519,6 @@ pub const VersionedConfirmedBlock = struct {
 
     pub fn deinit(self: @This(), allocator: Allocator) void {
         for (self.transactions) |it| it.deinit(allocator);
-        for (self.rewards) |it| it.deinit(allocator);
         allocator.free(self.transactions);
         allocator.free(self.rewards);
     }
@@ -1548,7 +1547,7 @@ const ConfirmedTransactionWithStatusMeta = struct {
     block_time: ?UnixTimestamp,
 };
 
-const TransactionWithStatusMeta = union(enum) {
+pub const TransactionWithStatusMeta = union(enum) {
     // Very old transactions may be missing metadata
     missing_metadata: Transaction,
     // Versioned stored transaction always have metadata
@@ -2498,6 +2497,7 @@ test getTransactionStatus {
         .loaded_addresses = .{},
         .return_data = .{},
         .compute_units_consumed = 1000,
+        .cost_units = null,
     };
 
     // insert transaction status and root it
@@ -2689,6 +2689,7 @@ test getConfirmedSignaturesForAddress {
         .loaded_addresses = .{},
         .return_data = .{},
         .compute_units_consumed = 1000,
+        .cost_units = null,
     };
     try write_batch.put(schema.transaction_status, .{ sig1, slot }, status_meta);
 

src/ledger/ResultWriter.zig

@@ -37,15 +37,18 @@ pub fn writeTransactionStatus(
     self: *const ResultWriter,
     slot: Slot,
     signature: Signature,
-    writeable_keys: ArrayList(Pubkey),
-    readonly_keys: ArrayList(Pubkey),
+    writeable_keys: []const Pubkey,
+    readonly_keys: []const Pubkey,
     status: TransactionStatusMeta,
     transaction_index: usize,
 ) !void {
-    try self.ledger.db.put(schema.transaction_status, .{ signature, slot }, status);
+    var write_batch = try self.ledger.db.initWriteBatch();
+    defer write_batch.deinit();
+
+    try write_batch.put(schema.transaction_status, .{ signature, slot }, status);
     inline for (.{ writeable_keys, readonly_keys }, .{ true, false }) |keys, writeable| {
-        for (keys.items) |address| {
-            try self.ledger.db.put(
+        for (keys) |address| {
+            try write_batch.put(
                 schema.address_signatures,
                 .{
                     .address = address,
@@ -57,6 +60,8 @@ pub fn writeTransactionStatus(
             );
         }
     }
+
+    try self.ledger.db.commit(&write_batch);
 }
 
 /// agave: insert_bank_hash

src/ledger/benchmarks.zig

@@ -19,7 +19,7 @@ fn createRewards(allocator: std.mem.Allocator, count: usize) !Rewards {
     var rewards: Rewards = Rewards.init(allocator);
     for (0..count) |i| {
         try rewards.append(Reward{
-            .pubkey = &Pubkey.initRandom(rand).data,
+            .pubkey = Pubkey.initRandom(rand),
             .lamports = @intCast(42 + i),
             .post_balance = std.math.maxInt(u64),
             .reward_type = RewardType.fee,
@@ -160,7 +160,7 @@ pub const BenchmarkLedger = struct {
         var indices = try std.array_list.Managed(u32).initCapacity(allocator, num_reads);
         defer indices.deinit();
         for (0..num_reads) |_| {
-            indices.appendAssumeCapacity(rng.random().uintAtMost(u32, @intCast(total_shreds)));
+            indices.appendAssumeCapacity(rng.random().uintAtMost(u32, @intCast(total_shreds - 1)));
         }
 
         const reader = state.reader();
@@ -247,7 +247,7 @@ pub const BenchmarkLedger = struct {
         var indices = try std.array_list.Managed(u32).initCapacity(allocator, total_shreds);
         defer indices.deinit();
         for (0..total_shreds) |_| {
-            indices.appendAssumeCapacity(rng.random().uintAtMost(u32, @intCast(total_shreds)));
+            indices.appendAssumeCapacity(rng.random().uintAtMost(u32, @intCast(total_shreds - 1)));
         }
 
         const reader = state.reader();
@@ -347,8 +347,8 @@ pub const BenchmarkLedger = struct {
             _ = try result_writer.writeTransactionStatus(
                 slot,
                 signature,
-                w_keys,
-                r_keys,
+                w_keys.items,
+                r_keys.items,
                 status,
                 tx_idx,
             );

src/ledger/tests.zig

@@ -416,6 +416,7 @@ pub fn insertDataForBlockTest(
                 .loaded_addresses = .{},
                 .return_data = .{},
                 .compute_units_consumed = compute_units_consumed,
+                .cost_units = null,
             };
             try db.put(schema.transaction_status, .{ signature, slot }, status);
             try db.put(schema.transaction_status, .{ signature, slot + 1 }, status);
@@ -435,6 +436,7 @@ pub fn insertDataForBlockTest(
                     .loaded_addresses = .{},
                     .return_data = .{},
                     .compute_units_consumed = compute_units_consumed,
+                    .cost_units = null,
                 },
             });
         }