feat(rpc): impl getAccountInfo RPC for accounts_db v2 by prestonsn · Pull Request #1217 · Syndica/sig

prestonsn · 2026-02-07T01:02:10Z

Implements getAccountInfo RPC for accounts db two. The PR is a bit large mostly due to porting over agave's account-decoder crate to zig. This also includes porting over all related unit tests.

There's some quirkiness (specific to SPL token 22 metadata accounts) in the code due to us not having a borsh lib available. Instead of implementing one that we may not need all the functionality of, this PR hand-rolls deserialization for things like an array of strings. The number of cases we need to handle was pretty minimal, so it didn't make sense implementing something more complete/robust.

Testing done (against Agave testnet RPC @ v3.1.8):

Category	What Was Tested
Encodings	jsonParsed, base64, base64+zstd, base58, fallback format
Commitment Levels	finalized, confirmed, processed
Parameters	dataSlice (offset/length)
SPL Token Mint	Fields: mintAuthority, supply, decimals, freezeAuthority, isInitialized
SPL Token Account	Fields: owner, mint, tokenAmount, state, isNative, delegate, closeAuthority
Token-2022	Discriminator offset, extension parsing, program name, MintCloseAuthority, TransferFee, InterestBearingConfig
Vote Account	Base fields + v4 SIMD-0185 fields (inflationRewardsCommissionBps, inflationRewardsCollector, blockRevenueCollector, blockRevenueCommissionBps, pendingDelegatorRewards, blsPubkeyCompressed)
Stake Account	Initialized state, stake: null handling
Address Lookup Table	Parsed data, kebab-case program name
BPF Upgradeable Loader	ProgramData, authority: null handling
Sysvars	Clock, EpochSchedule, EpochRewards, Rent, SlotHashes, StakeHistory, SlotHistory, LastRestartSlot
Response Structure	context.slot, context.apiVersion

codecov · 2026-02-08T01:20:26Z

Codecov Report

❌ Patch coverage is 95.26196% with 104 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/rpc/account_codec/parse_token_extension.zig	94.65%	39 Missing ⚠️
src/rpc/account_codec/lib.zig	80.95%	32 Missing ⚠️
src/rpc/account_codec/parse_vote.zig	83.33%	14 Missing ⚠️
src/rpc/account_codec/parse_sysvar.zig	97.00%	7 Missing ⚠️
...rpc/account_codec/parse_bpf_upgradeable_loader.zig	95.72%	5 Missing ⚠️
src/rpc/account_codec/parse_config.zig	94.73%	5 Missing ⚠️
src/core/hash.zig	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/core/epoch_schedule.zig	`98.96% <ø> (ø)`
...c/rpc/account_codec/parse_account_lookup_table.zig	`100.00% <100.00%> (ø)`
src/rpc/account_codec/parse_nonce.zig	`100.00% <100.00%> (ø)`
src/rpc/account_codec/parse_stake.zig	`100.00% <100.00%> (ø)`
src/rpc/account_codec/parse_token.zig	`100.00% <100.00%> (ø)`
src/rpc/methods.zig	`81.13% <ø> (+3.00%)`	⬆️
src/rpc/request.zig	`90.17% <100.00%> (ø)`
src/rpc/test_serialize.zig	`100.00% <100.00%> (ø)`
src/runtime/program/vote/state.zig	`96.10% <ø> (+0.10%)`	⬆️
src/runtime/program/vote/state_v4.zig	`94.22% <ø> (ø)`
... and 9 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

src/rpc/account_decoder/parse_token.zig

src/rpc/account_decoder/parse_config.zig

src/rpc/account_decoder/parse_bpf_upgradeable_loader.zig

src/rpc/methods.zig

src/rpc/account_codec/parse_account_lookup_table.zig

ajw221

initial review

src/cmd.zig

src/rpc/methods.zig

src/rpc/account_decoder/lib.zig

Implement the getAccountInfo RPC method with full support for all Solana account encodings: base58, base64, base64+zstd, and jsonParsed. - Add AccountHookContext with getAccountInfo method for reading account data - Support dataSlice parameter for partial account reads - Implement streaming zstd compression for base64+zstd encoding - Fall back to base64 encoding when no jsonParsed parser is available

- Agave v3.1.8 still supports it despite it being documented as deprected.

- Replace std.BoundedArray with inline buffer/len fields in JsonString and JsonArray - Add WriterError helper in base64.zig to support both GenericWriter and *std.io.Writer - Bridge base64+zstd path via adaptToNewApi for new Writer interface compatibility - Update JSON serialization: writeStream → Stringify, jw.stream → jw.writer - Change AccountData.jsonParsed from std.json.Value to []const u8 to avoid roundtrip parsing

ryu rust crate

@this

…ance - Remove redundant arena allocator in encodeJsonParsed; caller already provides per-request arena - Add errdefer for allocations in parse_vote.zig to prevent leaks with non-arena allocators - Pass dataSlice to jsonParsed base64 fallback path, matching Agave behavior (SPL tokens excluded) - Fix style violations: @this() in named structs, snake_case fn name, import ordering, container decl order - Rename parse_account to parseAccount, fix SlotNotFound -> SlotNotAvailable, remove stale TODOs

src/rpc/account_codec/parse_account_lookup_table.zig

prestonsn requested review from dnut, ultd and yewman as code owners February 7, 2026 01:02

github-project-automation bot added this to Sig Feb 7, 2026

github-project-automation bot moved this to 🏗 In progress in Sig Feb 7, 2026

prestonsn changed the base branch from main to adamw/implement-getSlot-in-rpc February 7, 2026 01:02

prestonsn marked this pull request as draft February 7, 2026 01:02

prestonsn self-assigned this Feb 7, 2026

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch from 40fae04 to 72d8727 Compare February 9, 2026 17:58

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 3 times, most recently from faf136b to ce30956 Compare February 10, 2026 21:27

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch from cf75dc5 to e7172e5 Compare February 11, 2026 16:22

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch from 40a15ee to 6afd364 Compare February 12, 2026 05:02

prestonsn force-pushed the adamw/implement-getSlot-in-rpc branch from e7172e5 to 0568f9e Compare February 12, 2026 22:08

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 3 times, most recently from 6477dcb to d912ade Compare February 12, 2026 22:41

ajw221 force-pushed the adamw/implement-getSlot-in-rpc branch from 7d84370 to 8279fe0 Compare February 14, 2026 03:24

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 6 times, most recently from 6945038 to 63d1d33 Compare February 17, 2026 04:08

Base automatically changed from adamw/implement-getSlot-in-rpc to main February 17, 2026 16:53

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 3 times, most recently from 3cb9dd6 to 4c29a67 Compare February 17, 2026 18:16

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 7 times, most recently from 8667355 to 1f15cea Compare February 19, 2026 00:08

prestonsn marked this pull request as ready for review February 19, 2026 00:57

yewman reviewed Feb 19, 2026

View reviewed changes

src/rpc/methods.zig Outdated Show resolved Hide resolved

src/rpc/methods.zig Outdated Show resolved Hide resolved

src/rpc/methods.zig Outdated Show resolved Hide resolved

hamza-syndica reviewed Feb 20, 2026

View reviewed changes

src/rpc/account_codec/parse_account_lookup_table.zig Show resolved Hide resolved

ajw221 requested changes Feb 20, 2026

View reviewed changes

src/cmd.zig Show resolved Hide resolved

src/rpc/methods.zig Outdated Show resolved Hide resolved

src/rpc/methods.zig Outdated Show resolved Hide resolved

src/rpc/methods.zig Outdated Show resolved Hide resolved

src/rpc/account_decoder/lib.zig Outdated Show resolved Hide resolved

github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig Feb 20, 2026

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch from 1f15cea to e0f6005 Compare February 23, 2026 02:51

yewman previously approved these changes Feb 23, 2026

View reviewed changes

prestonsn dismissed yewman’s stale review via 108bf64 February 23, 2026 19:21

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch 2 times, most recently from 288c270 to b67e6b1 Compare February 23, 2026 23:51

prestonsn added 3 commits February 26, 2026 00:03

fix(rpc): support deprected legacy base58 encoding

00a7d98

- Agave v3.1.8 still supports it despite it being documented as deprected.

prestonsn force-pushed the prestonsn/impl-get-account-info-for-db-two branch from b67e6b1 to a0a5842 Compare February 26, 2026 05:18

prestonsn added 4 commits February 26, 2026 05:22

clean-up(utils): remove unused json.Value eql helper

7ce8d07

fix(account_codec): conform with agave's float64 serialization via the

3567aa0

ryu rust crate

fix(rpc): document agave conformance shortfall in error code propagation

6e95df5

prestonsn commented Feb 27, 2026

View reviewed changes

src/rpc/account_codec/parse_account_lookup_table.zig Outdated Show resolved Hide resolved

fix(rpc): use correct top-level doc comment

3c6cfa4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rpc): impl getAccountInfo RPC for accounts_db v2#1217

feat(rpc): impl getAccountInfo RPC for accounts_db v2#1217
prestonsn wants to merge 8 commits intomainfrom
prestonsn/impl-get-account-info-for-db-two

prestonsn commented Feb 7, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajw221 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

prestonsn commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ajw221 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

prestonsn commented Feb 7, 2026 •

edited

Loading

codecov bot commented Feb 8, 2026 •

edited

Loading