Display selected characters in player panel and log #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuwizard
requested changes
Oct 14, 2025
| if (isset($data['player'])) { | ||
| $data['player_id'] = $data['player']->getId(); | ||
| $data['player_name'] = $data['player']->getName(); | ||
| $data['player_name'] = !isset($data['player_name']) ? $data['player']->getName() : $data['player_name']; |
Collaborator
There was a problem hiding this comment.
Could you please invert !isset to isset? It's harder to read ternary conditions when it starts with !
| return $this->name; | ||
| $name = $this->name; | ||
| if ($withCharacter && $this->getCharName()) { | ||
| $name .= ' (' . $this->getCharName() . ')'; |
Collaborator
There was a problem hiding this comment.
Can we go with JS-like syntax: $name = "{$name} ({$this->getCharName()})" ? It's much more readable IMO
Collaborator
|
Looks great overall actually, thanks for adding this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved https://en.boardgamearena.com/bug?id=61987
Some screenshots from BGA studio