If bad JSON comes back from Instagram, any server depending on it crashes#3
Open
kevinmarks wants to merge 1 commit intoSwizec:masterfrom
Open
If bad JSON comes back from Instagram, any server depending on it crashes#3kevinmarks wants to merge 1 commit intoSwizec:masterfrom
kevinmarks wants to merge 1 commit intoSwizec:masterfrom
Conversation
|
so, today is a bad day for instagram, and all we got in api answer so pls, apply kevinmarks patch |
|
Hi we're also seeing issues with crashes for instagram incoming data: /programs/server/npm/instagram-wrapper/main/node_modules/instagram/index.js:35:26) This patch been applied yet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I caught the exception that JSON.parse throws, which means the server no longer crashes (I think it's an encoding escaping issue on instagram's end, but it was crashing my test server consistently on some tag queries). Feel free to add some better logging to the catch.