Don't create pmd:codesUsed collections for measure types. #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #88 - Only create codesUsed collections for dimension and attribute columns. Add codes_used column to intermediate component specifications file. Update related metadata to include this new column. The column has a value (of "yes") to indicate if the component should have an associated pmd:codesUsed property relating it to a code list. Update the corresponding CSVW metadata to only output codesUsed codelists connected to the corresponding components for dimension and attribute columns.
Contributor
|
Thanks Lee. It's a pity csvw doesn't have a more convenient mechanism to express conditional processing. Having a flag column feels a bit unsatisfactory - especially since the "yes" is irrelevant, I guess any non-empty value would suffice, even a "no"! Perhaps putting in the codes-used collection URI (or the template) would be more meaningful? |
Robsteranium
suggested changes
Jan 14, 2019
Contributor
Robsteranium
left a comment
Robsteranium
left a comment
There was a problem hiding this comment.
Sorry, it looks like I put this comment in the wrong place: #94 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #88 - Only create codesUsed collections for dimension and
attribute columns.
Add codes_used column to intermediate component specifications
file. Update related metadata to include this new column. The
column has a value (of "yes") to indicate if the component
should have an associated pmd:codesUsed property relating it to
a code list.
Update the corresponding CSVW metadata to only output codesUsed
codelists connected to the corresponding components for dimension
and attribute columns.