Refactor/zoom frame #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This widget was overly bloated considering the things that it actually needed to manage. For example, we were storing several different types of width/height, even though the only "important" ones are the widget dimensions and the dimensions of each image.
If we tried to load an invalid TextGrid file, that would cause the program to raise a (native) TextGrid error and crash us.
mr-martian
reviewed
Dec 17, 2019
jonorthwash
force-pushed
the
master
branch
3 times, most recently
from
81d5a96 to
9d1c199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies some of the internal structure of the
ZoomFramewidget towards an ultimate goal of generally refactoring our widgets.In particular, I think we should move away from modifying internal state of classes directly, and instead rely on small functions that perform single tasks (see, for example, splitting
ZoomFrame::wheelintoZoomFrame::zoom{,in,out}), as well as only maintaining the minimal amount of state that cannot be derived.If you guys have a chance, could you take a look at this PR and just make sure it still works for you? Ultimately, we should be also moving towards a unit-testing framework, as that will enable us to make these larger refactoring changes without worrying about breaking compatibility.