Skip to content

251114_10_허준서 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Junseo0324 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

251114_10_허준서 #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa629c
feat: 디버깅 연습문제 2
Junseo0324 Nov 14, 2025
28c8fea
feat: 디버깅 연습문제 2
Junseo0324 Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 22 additions & 43 deletions src/main/kotlin/YukymController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,59 +5,38 @@ import java.time.format.DateTimeFormatter

class YukymController {

val nowDate = LocalDateTime.now().format(DateTimeFormatter.ofPattern("yyyy-mm-dd"))

lateinit var nowTime: String
val nowDate = LocalDateTime.now()
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

nowDate가 컨트롤러 생성 시점에 고정됩니다.

nowDate가 val로 선언되어 있어 YukymController 인스턴스 생성 시점의 시간으로 고정됩니다. 컨트롤러 인스턴스를 재사용할 경우 getTyA()와 getTyB()가 오래된 시간 정보를 사용하게 되어 잘못된 결과를 반환할 수 있습니다.

다음 diff를 적용하여 메서드 호출 시점의 현재 시간을 사용하도록 수정하세요:

-    val nowDate = LocalDateTime.now()
+    val nowDate: LocalDateTime
+        get() = LocalDateTime.now()
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
val nowDate = LocalDateTime.now()
val nowDate: LocalDateTime
get() = LocalDateTime.now()
🤖 Prompt for AI Agents 
In src/main/kotlin/YukymController.kt around line 8, nowDate is declared as val
nowDate = LocalDateTime.now() which fixes the timestamp at controller
construction; change it so the current time is obtained at each method call
(move LocalDateTime.now() into getTyA() and getTyB(), or replace the val with a
function/property that calls LocalDateTime.now() on access) so both methods use
the call-time timestamp instead of the construction-time value.


fun getTyA(): String {
val timeDataOne = _getTimeDataOne(nowDate)

if (timeDataOne.isNotEmpty()) {
nowTime = timeDataOne.first().ty1

val month = nowDate.substring(5, 7)
return when (month) {
"01", "02" -> "경오1국"
"03", "04" -> "경오2국"
"05", "06" -> "경오3국"
"07", "08" -> "경오4국"
"09", "10" -> "경오5국"
"11", "12" -> "경오6국"
else -> nowTime
}
} else {
return "경오7국"
return when (nowDate.monthValue) {
1,2 -> "경오1국"
3,4 -> "경오2국"
5,6 -> "경오3국"
7,8 -> "경오4국"
9,10 -> "경오5국"
11,12 -> "경오6국"
else -> "경오7국"
}
Comment on lines +11 to 19
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

도달 불가능한 else 절이 있습니다.

monthValue는 항상 1부터 12까지의 값이므로 18번 줄의 else -> "경오7국" 절은 도달할 수 없는 코드입니다.

다음 diff를 적용하여 불필요한 else 절을 제거하세요:

         return when (nowDate.monthValue) {
             1,2 -> "경오1국"
             3,4 -> "경오2국"
             5,6 -> "경오3국"
             7,8 -> "경오4국"
             9,10 -> "경오5국"
-            11,12 -> "경오6국"
-            else -> "경오7국"
+            else -> "경오6국"  // 11,12
         }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
return when (nowDate.monthValue) {
1,2 -> "경오1국"
3,4 -> "경오2국"
5,6 -> "경오3국"
7,8 -> "경오4국"
9,10 -> "경오5국"
11,12 -> "경오6국"
else -> "경오7국"
}
return when (nowDate.monthValue) {
1,2 -> "경오1국"
3,4 -> "경오2국"
5,6 -> "경오3국"
7,8 -> "경오4국"
9,10 -> "경오5국"
else -> "경오6국" // 11,12
}
🤖 Prompt for AI Agents 
In src/main/kotlin/YukymController.kt around lines 11 to 19, the when-expression
includes an unreachable else branch because nowDate.monthValue is guaranteed to
be 1..12; remove the else -> "경오7국" arm and convert the when to be exhaustive by
relying on the existing 1..12 cases (no default branch needed), or if the
compiler requires exhaustiveness, replace else with a specific range or throw an
IllegalStateException to reflect impossible state.

}

fun getTyB(): String {
val timeDataOne = _getTimeDataOne(nowDate)
var result = timeDataOne.first().ty12

val nowTime = LocalDateTime.now()
when {
nowTime.hour >= 0 || nowTime.hour < 2 -> return timeDataOne.first().ty1
nowTime.hour >= 4 || nowTime.hour < 6 -> return timeDataOne.first().ty2
nowTime.hour >= 6 || nowTime.hour < 8 -> return timeDataOne.first().ty3
nowTime.hour >= 8 || nowTime.hour < 10 -> return timeDataOne.first().ty4
nowTime.hour >= 10 || nowTime.hour < 12 -> return timeDataOne.first().ty5
nowTime.hour >= 12 || nowTime.hour < 14 -> return timeDataOne.first().ty6
nowTime.hour >= 16 || nowTime.hour < 18 -> return timeDataOne.first().ty7
nowTime.hour >= 18 || nowTime.hour < 20 -> return timeDataOne.first().ty8
nowTime.hour >= 20 || nowTime.hour < 22 -> return timeDataOne.first().ty9
nowTime.hour >= 22 || nowTime.hour < 24 -> return timeDataOne.first().ty10
val timeData = YukymTimeModel()
return when (nowDate.hour) {
in 0..1 -> timeData.ty1
in 4..5 -> timeData.ty2
in 6..7 -> timeData.ty3
in 8..9 -> timeData.ty4
in 10..11 -> timeData.ty5
in 12..13 -> timeData.ty6
in 16..17 -> timeData.ty7
in 18..19 -> timeData.ty8
in 20..21 -> timeData.ty9
in 22..23 -> timeData.ty10
else -> timeData.ty12
}

return result
}
Comment on lines 22 to 38
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

시간대 매핑에 누락된 구간이 있고 비효율적인 인스턴스 생성이 있습니다.

다음과 같은 문제가 있습니다:

  1. 시간대 누락: 2-3시와 14-15시가 when 표현식에서 누락되어 ty12로 폴백됩니다. 이것이 의도된 동작인지 확인이 필요합니다.
  2. 비효율적인 인스턴스 생성: 23번 줄에서 매 호출마다 새로운 YukymTimeModel 인스턴스를 생성하고 있습니다. 기본값만 사용하므로 companion object로 추출하는 것이 효율적입니다.
  3. 미사용 필드: YukymTimeModel의 ty11은 정의되어 있지만 when 표현식에서 사용되지 않습니다.

누락된 시간대를 추가하거나 의도를 명확히 하는 diff:

         return when (nowDate.hour) {
             in 0..1 -> timeData.ty1
+            in 2..3 -> timeData.ty11  // 또는 의도에 맞는 다른 값
             in 4..5 -> timeData.ty2
             in 6..7 -> timeData.ty3
             in 8..9 -> timeData.ty4
             in 10..11 -> timeData.ty5
             in 12..13 -> timeData.ty6
+            in 14..15 -> timeData.ty11  // 또는 의도에 맞는 다른 값
             in 16..17 -> timeData.ty7
             in 18..19 -> timeData.ty8
             in 20..21 -> timeData.ty9
             in 22..23 -> timeData.ty10
             else -> timeData.ty12
         }

YukymTimeModel을 companion object로 추출하는 리팩토링:

 class YukymController {
 
     val nowDate: LocalDateTime
         get() = LocalDateTime.now()
+    
+    companion object {
+        private val TIME_DATA = YukymTimeModel()
+    }
 
     fun getTyA(): String {
         // ...
     }
 
     fun getTyB(): String {
-        val timeData = YukymTimeModel()
-        return when (nowDate.hour) {
-            in 0..1 -> timeData.ty1
+        return when (nowDate.hour) {
+            in 0..1 -> TIME_DATA.ty1
             // ... (모든 timeData를 TIME_DATA로 변경)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
fun getTyB(): String {
val timeDataOne = _getTimeDataOne(nowDate)
var result = timeDataOne.first().ty12
val nowTime = LocalDateTime.now()
when {
nowTime.hour >= 0 || nowTime.hour < 2 -> return timeDataOne.first().ty1
nowTime.hour >= 4 || nowTime.hour < 6 -> return timeDataOne.first().ty2
nowTime.hour >= 6 || nowTime.hour < 8 -> return timeDataOne.first().ty3
nowTime.hour >= 8 || nowTime.hour < 10 -> return timeDataOne.first().ty4
nowTime.hour >= 10 || nowTime.hour < 12 -> return timeDataOne.first().ty5
nowTime.hour >= 12 || nowTime.hour < 14 -> return timeDataOne.first().ty6
nowTime.hour >= 16 || nowTime.hour < 18 -> return timeDataOne.first().ty7
nowTime.hour >= 18 || nowTime.hour < 20 -> return timeDataOne.first().ty8
nowTime.hour >= 20 || nowTime.hour < 22 -> return timeDataOne.first().ty9
nowTime.hour >= 22 || nowTime.hour < 24 -> return timeDataOne.first().ty10
val timeData = YukymTimeModel()
return when (nowDate.hour) {
in 0..1 -> timeData.ty1
in 4..5 -> timeData.ty2
in 6..7 -> timeData.ty3
in 8..9 -> timeData.ty4
in 10..11 -> timeData.ty5
in 12..13 -> timeData.ty6
in 16..17 -> timeData.ty7
in 18..19 -> timeData.ty8
in 20..21 -> timeData.ty9
in 22..23 -> timeData.ty10
else -> timeData.ty12
}
return result
}
fun getTyB(): String {
val timeData = YukymTimeModel()
return when (nowDate.hour) {
in 0..1 -> timeData.ty1
in 2..3 -> timeData.ty11
in 4..5 -> timeData.ty2
in 6..7 -> timeData.ty3
in 8..9 -> timeData.ty4
in 10..11 -> timeData.ty5
in 12..13 -> timeData.ty6
in 14..15 -> timeData.ty11
in 16..17 -> timeData.ty7
in 18..19 -> timeData.ty8
in 20..21 -> timeData.ty9
in 22..23 -> timeData.ty10
else -> timeData.ty12
}
}


private fun _getTimeDataOne(nowDate: String): List<YukymTimeModel> {
val timeDataOne = mutableListOf<YukymTimeModel>()
for (i in 0..24) {
timeDataOne.add(YukymTimeModel())
}
return timeDataOne
}
}

data class YukymTimeModel(
Expand Down