Skip to content

Conversation

@marchuk-vlad
Copy link
Collaborator

@marchuk-vlad marchuk-vlad commented Dec 18, 2025

Summary by CodeRabbit

Release Notes

Chores

  • Updated @super-protocol/sdk-js dependency from 3.15.2 to 3.18.1 in ComfyUI and Text Generation WebUI for enhanced compatibility and stability.
  • Text Generation WebUI package version incremented from 0.5.4 to 0.5.6.

✏️ Tip: You can customize this high-level summary in your review settings.

@marchuk-vlad marchuk-vlad requested a review from Idris0v December 18, 2025 12:53
@marchuk-vlad marchuk-vlad self-assigned this Dec 18, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 18, 2025

Walkthrough

Dependency version updates applied across two package.json files: @super-protocol/sdk-js bumped from 3.15.2 to 3.18.1 in both ComfyUI and Text Generation WebUI projects. Package version for Text Generation WebUI incremented from 0.5.4 to 0.5.6. No functional code changes.

Changes

Cohort / File(s) Summary
Dependency Updates
ComfyUI/package.json, Text Generation WebUI/package.json
@super-protocol/sdk-js version bumped from 3.15.2 to 3.18.1 in both files. Text Generation WebUI package version also updated from 0.5.4 to 0.5.6.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • No logic changes or functional modifications to review
  • Simple version number updates only
  • Consistent change pattern across files

Possibly related PRs

Poem

🐰 Dependencies dance and versions spin,
SDK updates roll on in,
From 3.15 to 3.18 they leap,
New features bundled, promises to keep!
Hop, hop, hooray—the packages align!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update to sdk 3.18.1' directly matches the main change: bumping @super-protocol/sdk-js from 3.15.2 to 3.18.1 across multiple package.json files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch solutions-sdk-4-0-18

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a0cc917 and 613086c.

⛔ Files ignored due to path filters (2)
  • ComfyUI/package-lock.json is excluded by !**/package-lock.json
  • Text Generation WebUI/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • ComfyUI/package.json (1 hunks)
  • Text Generation WebUI/package.json (2 hunks)
🧰 Additional context used
🧠 Learnings (6)
📓 Common learnings
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI uses numerical version tags like 0.3.10 and 0.3.29 (without "v" prefix) in its GitHub repository, and its changelog can be viewed using the compare URL format: https://github.com/comfyanonymous/ComfyUI/compare/[old_version]...[new_version]
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI uses versioned tags with "v" prefix (like v0.3.29) in its GitHub repository at comfyanonymous/ComfyUI.
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI Manager uses versioned tags without "v" prefix (like 3.31.12) in its GitHub repository at Comfy-Org/ComfyUI-Manager.
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:44:51.328Z
Learning: ComfyUI Manager repository has moved from jiangyangfan/ComfyUI-Manager to Comfy-Org/ComfyUI-Manager, and the comfy CLI handles this change transparently when using the --manager-commit parameter.
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:44:51.328Z
Learning: ComfyUI Manager repository has moved from jiangyangfan/ComfyUI-Manager to Comfy-Org/ComfyUI-Manager, and the comfy CLI handles this change transparently when using the --manager-commit parameter.
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI Manager uses numerical version tags like 3.6.5 and 3.31.12 (without "v" prefix) in the Comfy-Org GitHub repository, and its changelog can be viewed using the compare URL format: https://github.com/Comfy-Org/ComfyUI-Manager/compare/[old_version]...[new_version]
📚 Learning: 2025-04-24T09:44:51.328Z
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:44:51.328Z
Learning: ComfyUI Manager repository has moved from jiangyangfan/ComfyUI-Manager to Comfy-Org/ComfyUI-Manager, and the comfy CLI handles this change transparently when using the --manager-commit parameter.

Applied to files:

  • ComfyUI/package.json
📚 Learning: 2025-04-24T09:49:17.947Z
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI uses numerical version tags like 0.3.10 and 0.3.29 (without "v" prefix) in its GitHub repository, and its changelog can be viewed using the compare URL format: https://github.com/comfyanonymous/ComfyUI/compare/[old_version]...[new_version]

Applied to files:

  • ComfyUI/package.json
📚 Learning: 2025-04-24T09:49:17.947Z
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI Manager uses versioned tags without "v" prefix (like 3.31.12) in its GitHub repository at Comfy-Org/ComfyUI-Manager.

Applied to files:

  • ComfyUI/package.json
📚 Learning: 2025-04-24T09:49:17.947Z
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI Manager uses numerical version tags like 3.6.5 and 3.31.12 (without "v" prefix) in the Comfy-Org GitHub repository, and its changelog can be viewed using the compare URL format: https://github.com/Comfy-Org/ComfyUI-Manager/compare/[old_version]...[new_version]

Applied to files:

  • ComfyUI/package.json
📚 Learning: 2025-04-24T09:49:17.947Z
Learnt from: tinovyatkin
Repo: Super-Protocol/solutions PR: 101
File: ComfyUI/Dockerfile.local-cpu:29-30
Timestamp: 2025-04-24T09:49:17.947Z
Learning: ComfyUI uses versioned tags with "v" prefix (like v0.3.29) in its GitHub repository at comfyanonymous/ComfyUI.

Applied to files:

  • ComfyUI/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-engine
🔇 Additional comments (2)
Text Generation WebUI/package.json (1)

3-3: Package version bump looks reasonable.

Version incremented from 0.5.4 to 0.5.6 (skipping 0.5.5). This is acceptable and may align with release scheduling or previous version management.

ComfyUI/package.json (1)

26-26: SDK update is consistent across packages.

The SDK version update from 3.15.2 to 3.18.1 matches the update in Text Generation WebUI, ensuring consistency across the solution packages. Verification of the SDK version and breaking changes has been requested in the Text Generation WebUI package.json review.

},
"dependencies": {
"@super-protocol/sdk-js": "3.15.2",
"@super-protocol/sdk-js": "3.18.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Package.json references non-existent SDK version.

The specified version 3.18.1 does not exist; the latest version of @super-protocol/sdk-js is 3.7.5. Installing this will fail. Verify the intended version number—possibly a typo or a version from a different registry.

🤖 Prompt for AI Agents
In Text Generation WebUI/package.json at line 27, the dependency
"@super-protocol/sdk-js": "3.18.1" references a non-existent version; replace it
with a valid published version (e.g., "3.7.5") or the correct intended version
from the proper registry, then update the lockfile by running npm install (or
yarn install) and verify installation succeeds; if this version was expected
from a private registry, ensure the registry/config is correct before changing
the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants