Optimise SaveUsersStatsSnapshots + small fix for new ranks #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardscull
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimises
SaveUsersStatsSnapshotsand fixesGetUserRanksto not increment on ranks if in the recursion (previously, if it didn't find the user rank, it would increment twice to the user rank).We also now don't save the snapshot for stats which doesn't have any performance points.
Numbers wise, snapshots now take 30 times less time to save.
Ex: Previously for 100 users to same all stats in all gamemodes, would require 30s, now it requires only 1 second.