Add hopper discharge, rotating drum examples and measurement plane enhancements#13
Open
Add hopper discharge, rotating drum examples and measurement plane enhancements#13
Conversation
…hancements Measurement plane enhancements (dem_measure_plane): - Circular measurement planes (shape="circular" + radius) for cylindrical geometries - Rolling average statistics (rolling_windows) for smoothed flow rate tracking - Per-type measurement (per_type=true) to track different particle types separately - New tests for circular bounds checking and rolling history Cylinder wall angular velocity (dem_wall): - Add angular_velocity field to WallCylinder for rotating cylinder walls - Compute wall surface velocity at contact point via omega × r - Apply Coulomb-limited tangential friction force opposing relative sliding - Compute torque on particles from wall friction Hopper discharge example: - Slot hopper with funnel walls, blocker wall removal on settling - Measurement plane at outlet tracks mass flow rate (Beverloo validation case) - Rolling average flow rate for smoother statistics - Two-stage simulation: filling → flowing Rotating drum example: - Z-axis cylinder with angular_velocity = 1 rad/s (~10 RPM) - Particles inside drum, gravity in -y creates avalanching flow - Demonstrates dynamic angle of repose in rolling/cascading regime - Froude number ≈ 0.005 (well below centrifuging transition) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Maintainer Review: ❌ CHANGES REQUESTEDGood feature work — measurement plane enhancements and cylinder angular velocity are well-designed. However, both example configs have a blocking bug. Blocking: Invalid TOML config formatBoth [comm]
processors = [1, 1, 1]
Fix: Replace with: [comm]
processors_x = 1
processors_y = 1
processors_z = 1Non-blocking
Please fix the config format and I'll merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test --no-default-features --workspace— all 26 crate tests passcargo clippy --no-default-features -- -D warnings— no warningshopper_dischargeexample and verify mass flow rate outputrotating_drumexample and verify avalanching behavior in VTP output🤖 Generated with Claude Code