Open
Conversation
removed all obsolute references to self.dotFile added a couple of docstrings
…ines for running the actor from simulated data, including fake dot mask routines.
checked that all routines have basc docstring
removed unneeded Visualizations directory, plus some obsolute testing stuff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tidying of the MCS actor removing obsolete and unused code; In addition to unused routines, I excised the references to old methods for using simulated data, which I don't think have been used at least since early in the commissioning/integration phase.
I'd like someone else to take a quick look a the changes, to make sure I haven't deleted something still in use. I left in routines for interactive resetting/setting of parameters, as potentially useful for debugging or unusual situations.
I've tested in simtron, but that only works up to the fibre identification, due to the mismatch between cobra configurations resulting in the matching failing.