Document operational rationale for aws-es-proxy master tag#15
Merged
alan-walsh merged 2 commits intofeat/aws-es-proxy-master-tagfrom Mar 26, 2026
Merged
Document operational rationale for aws-es-proxy master tag#15alan-walsh merged 2 commits intofeat/aws-es-proxy-master-tagfrom
alan-walsh merged 2 commits intofeat/aws-es-proxy-master-tagfrom
Conversation
Co-authored-by: alan-walsh <12358329+alan-walsh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on using master tag for aws-es-proxy image in both environments
Document operational rationale for aws-es-proxy master tag
Mar 11, 2026
alan-walsh
approved these changes
Mar 26, 2026
There was a problem hiding this comment.
Pull request overview
Documents why aws-es-proxy must remain pinned to the mutable master tag by adding an inline rationale comment in both environment Helm values files.
Changes:
- Added a comment explaining that
quay.io/cdis/aws-es-proxydoes not publish immutable release/date tags. - Applied the same comment to both
prdanddmovalues files for consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ardac1prd/portal.ardac.org/values.yaml | Adds inline rationale for using aws-es-proxy image tag master. |
| ardac1dmo/demo.ardac.org/values.yaml | Mirrors the same rationale comment for consistency across environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quay.io/cdis/aws-es-proxydoes not publish immutable release/date tags —masteris the only available tag. Added an inline comment to both environmentvalues.yamlfiles to document this constraint, addressing the reviewer's request for explicit rationale when a mutable tag must be used.Changes
ardac1prd/portal.ardac.org/values.yaml— comment abovetag: "master"explaining the image doesn't publish versioned tagsardac1dmo/demo.ardac.org/values.yaml— same comment for consistency🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.