MODIFIED: Filter Logging System Panic#24
Open
Sommos wants to merge 1 commit intoStumblinbear:masterfrom
Open
Conversation
Owner
|
Technically yes, but the likelyhood of this failing to parse is zero since it's guaranteed to be well-formed. Generally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are calling unwrap() on the result of a parse(). The unwrap() function returns the value inside an Ok variant, but if the Result is an Err, it will cause the program to panic and terminate.
Pull request type
Potential Bug Fix
Please check the type of change your PR introduces:
What is the current behavior?
Currently, calling unwrap() on the result of parse() within these filters can cause the program to panic and terminate if an Err is returned instead of the expected Ok.
Issue Number: N/A
What is the new behavior?
Other information
N/A