Fix mobile scaling -training #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change user-scalable=yes
ExtraGravity
requested changes
Nov 5, 2017
Contributor
ExtraGravity
left a comment
ExtraGravity
left a comment
There was a problem hiding this comment.
Good, the user-scalable doesn't need to be set, it's an artifact from a copy paste :)
As to your question, setting the max min scale isn't necessary. This training isn't really meant for mobile anyways, this line of code was included just so it would look reasonable on a mobile screen.
| <meta content="text/html; charset=utf-8" http-equiv="content-type"> | ||
| <meta name="viewport" content="width=device-width, user-scalable=no"> | ||
| <meta name="viewport" content="width=device-width, user-scalable=yes"> | ||
| #if you are allowing it to be scalable, do you need to set an intial scale |
Contributor
There was a problem hiding this comment.
Let's remove this comment. Also, by default user-scalable is yes, so to fix this the best would be just to remove the whole user-scalable=no` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change user-scalable=yes
By allowing it to be user scalable do we need to set an initial or a max/min scale as well?