Skip to content

Conversation

@geeksville
Copy link
Contributor

Checks

Seems to work well enough for me.

@Core447
Copy link
Member

Core447 commented Jan 6, 2026

Nice work! What I noticed:

  • please remove the requirements.txt file. As anything in there causes it to be (re-)installed in the environment of the app itself and we already ship websocket-client with the app.
  • it would be nice to have some info text in the action config area, telling the user to install the vscode extension (for inspiration check out the Discord plugin)
  • for consistency reasons please rename your plugin to don't include StreamController in the name. Otherwise it's a bit weird in the action selector if only one plugin starts with "StreamController!

Feel free to ping me if you have any questions or are ready for merge.

@geeksville
Copy link
Contributor Author

Sounds good! Will do. Thanks for making this btw.

@Core447
Copy link
Member

Core447 commented Jan 7, 2026

Great! Just update the hash when you're ready.

@geeksville
Copy link
Contributor Author

ok good to go now I think! Also I moved the hostname/portnum settings out of the Actions into a new plugin wide settings screen.

@Core447
Copy link
Member

Core447 commented Jan 9, 2026

Nice work!

@Core447 Core447 merged commit 11bd8e5 into StreamController:main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants