Skip to content

Fix output string building #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coj337 merged 1 commit into from
Jun 4, 2025
Merged

Fix output string building #13

coj337 merged 1 commit into from
Jun 4, 2025

Conversation

@coj337
Copy link
Contributor

@coj337 coj337 commented Jun 4, 2025

Summary

  • build locationString first
  • only include CNAME text when applicable and generate final output string after determining locationString
  • use the same string for console and file output

Testing

  • dotnet test --no-build --verbosity minimal (fails: Azure.Identity InteractiveBrowserCredential cannot acquire token)

https://chatgpt.com/codex/tasks/task_e_683ff825d554832f9350e8b42ab68f40

@coj337 coj337 merged commit 1afabca into master Jun 4, 2025
1 check failed
@coj337 coj337 deleted the codex/build-output-line-with-conditional-cname branch June 4, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coj337