Skip to content

build: Поднятие версии netcore до 8.0#37

Merged
Stivo182 merged 1 commit intomainfrom
build/bump-netcore
Feb 19, 2026
Merged

build: Поднятие версии netcore до 8.0#37
Stivo182 merged 1 commit intomainfrom
build/bump-netcore

Conversation

@Stivo182
Copy link
Owner

@Stivo182 Stivo182 commented Feb 19, 2026

Summary by CodeRabbit

  • New Features

    • Added support for .NET 8.0 runtime environment.
  • Bug Fixes

    • Fixed a typo in an error message related to missing components.
  • Chores

    • Version bumped to 1.1.0.
    • Updated package dependencies to support new runtime.

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

📝 Walkthrough

Walkthrough

Updates project target frameworks from .NET 6.0 to .NET 8.0, replaces NET6_0_OR_GREATER preprocessor symbols with NETCOREAPP, updates OneScript.StandardLibrary package versions, bumps project versions to 1.1.0, and fixes a Russian language typo in an error message.

Changes

Cohort / File(s) Summary
Build Configuration
build/ПодготовкаКомпонентов.os, src/BenchmarkOneScript.Extensions/BenchmarkOneScript.Extensions.csproj, src/Chronometer/ChronometerOneScript.csproj
Target framework updated from net6.0 to net8.0; project versions bumped from 1.0.0 to 1.1.0; OneScript.StandardLibrary package dependencies updated from 2.0.0-rc6 to 2.0.0 for net8.0 target. Fixed typo in Russian error message ("Отсутсвует" → "Отсутствует").
Conditional Compilation Updates
src/BenchmarkOneScript.Extensions/TypeExtension.cs, src/Chronometer/Chronometer.cs
Replaced preprocessor symbol NET6_0_OR_GREATER with NETCOREAPP; OneScript.Contexts usage now gated behind NETCOREAPP conditional; behavior remains functionally equivalent.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #36: Modifies the same Chronometer.cs and build script files; appears to involve chronometer implementation changes alongside framework updates.

Poem

🐰 Six was great, but Eight's the way,
With frameworks updated and typos at bay,
Conditional symbols dance new and bright,
Dependencies polished—everything's right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: upgrading the .NET Core target framework from net6.0 to net8.0 across multiple project files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch build/bump-netcore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/Chronometer/ChronometerOneScript.csproj (1)

4-4: Nit: trailing semicolons in TargetFrameworks.

Both this file and BenchmarkOneScript.Extensions.csproj have a trailing semicolon in <TargetFrameworks>net48;net8.0;</TargetFrameworks>. While MSBuild handles it gracefully, removing it keeps the value canonical: net48;net8.0.

Proposed fix
-		<TargetFrameworks>net48;net8.0;</TargetFrameworks>
+		<TargetFrameworks>net48;net8.0</TargetFrameworks>
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/Chronometer/ChronometerOneScript.csproj` at line 4, The TargetFrameworks
element contains a trailing semicolon
("<TargetFrameworks>net48;net8.0;</TargetFrameworks>") which should be
canonicalized; open the ChronometerOneScript.csproj (and
BenchmarkOneScript.Extensions.csproj) and remove the trailing semicolon so the
value reads "net48;net8.0" in the TargetFrameworks element, preserving XML
formatting and spacing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/Chronometer/ChronometerOneScript.csproj`:
- Line 4: The TargetFrameworks element contains a trailing semicolon
("<TargetFrameworks>net48;net8.0;</TargetFrameworks>") which should be
canonicalized; open the ChronometerOneScript.csproj (and
BenchmarkOneScript.Extensions.csproj) and remove the trailing semicolon so the
value reads "net48;net8.0" in the TargetFrameworks element, preserving XML
formatting and spacing.

@sonar-openbsl-ru-qa-bot
Copy link

@Stivo182 Stivo182 merged commit a2296b7 into main Feb 19, 2026
32 checks passed
@Stivo182 Stivo182 deleted the build/bump-netcore branch February 19, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant