Skip to content

Comments

Adjust UI elements and update version name#28

Merged
Steve-Mr merged 2 commits intomainfrom
dev
Jun 29, 2025
Merged

Adjust UI elements and update version name#28
Steve-Mr merged 2 commits intomainfrom
dev

Conversation

@Steve-Mr
Copy link
Owner

This PR focuses on refining the user interface and updating the application's version name. The changes include improvements to corner shapes, top app bar styling, and switch colors for a more consistent and visually appealing experience.

Steve-Mr added 2 commits June 29, 2025 17:52
This commit updates the UI for a more consistent look and feel:

- **Rounded Corners:** The corner radius for grouped `SettingsItem` elements in `SettingsComponents.kt` has been increased from 4.dp to 8.dp for `MIDDLE` and the inner edges of `TOP` and `BOTTOM` positions.
- **Color Scheme Update in SettingsScreen:**
    - The `TopAppBar` now uses `tertiaryContainer` for its background and `tertiary` for its content.
    - `IconButton`s in the `TopAppBar` now have a `tertiary` background and `onTertiary` content color.
    - The main background of the `SettingsScreen` is now `tertiaryContainer`.
    - `SettingsItem`s now use `primaryContainer` as their background.
    - `SwitchRow` in the "Default Channel" setting now uses `primary` for its switch color.
    - The "Notification Settings" `TextContent` now uses `primary` for its text color.
- **TopAppBar Title Alignment:** The title in the `TopAppBar` is now centered.
- **TopAppBar Title Style:** Removed custom font weight and style from the `TopAppBar` title.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Steve-Mr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the application's user interface to provide a more consistent and visually appealing experience. Key changes include adjustments to corner shapes, a comprehensive update to the top app bar's styling and colors, and a broader alignment of component colors across the settings screen. Additionally, the application's version name has been updated.

Highlights

  • UI Corner Shapes Refinement: Adjusted the RoundedCornerShape values for SettingsItem components, increasing the inner corner radii from 4dp to 8dp for TOP, MIDDLE, and BOTTOM group positions to enhance visual consistency.
  • Top App Bar Styling Update: Reworked the TopAppBar's color scheme to use tertiaryContainer and tertiary colors, centered the title text, and applied specific IconButtonDefaults colors to the navigation and action icons for a more cohesive look.
  • Component Color Scheme Alignment: Updated various UI component colors, including the main screen background, SettingsItem containers, SwitchRow switches, and TextContent elements, to align with the new primaryContainer and primary color scheme, improving overall visual harmony.
  • Application Version Update: The application's versionName in app/build.gradle has been updated from '2025.06.20_01' to '2025.06.29'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively refines the user interface elements and updates the application's version name, aligning with the stated objective of a more consistent and visually appealing experience. The changes to corner shapes, top app bar styling, and switch colors are well-implemented UI adjustments. The only potential area for improvement identified is related to the consistency of the versionName format, which could impact release management if a specific convention was previously in place.

targetSdk 35
versionCode 5
versionName "2025.06.20_01"
versionName "2025.06.29"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The versionName format has changed from YYYY.MM.DD_BUILD to YYYY.MM.DD. If the _BUILD suffix was previously used to denote a specific build or patch version for a given day, its removal might lead to a loss of granularity in version tracking. Consider maintaining a consistent versioning scheme, especially if automated tools or release processes rely on such details for traceability.

@Steve-Mr Steve-Mr merged commit c284e9e into main Jun 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant