Skip to content

Conversation

@sakari-malkki
Copy link
Member

No description provided.

@sakari-malkki sakari-malkki marked this pull request as ready for review September 9, 2025 07:58
@sakari-malkki sakari-malkki force-pushed the feature/key-figure-visualizationtype branch from 774616c to 22ca73e Compare September 25, 2025 12:02
@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new KeyFigure visualization type for displaying single statistical values in a card-like format. The implementation includes React components, styling, and HTML rendering capabilities specifically designed for key figure displays.

  • Adds KeyFigure as a new visualization type alongside existing charts and tables
  • Implements React component and HTML rendering for key figure display with styling support
  • Includes comprehensive test coverage and Storybook stories for the new feature

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/stories/tablestories/keyfigure.stories.tsx Storybook stories demonstrating basic and custom-styled key figure components
src/react/components/globalStyle/globalStyle.ts Global CSS styles for key figure elements
src/react/components/chart/keyFigureView.tsx React component for rendering key figure visualizations
src/react/components/chart/keyFigureView.test.tsx Unit tests for the KeyFigureView component
src/react/components/chart/chart.tsx Integration of KeyFigure type into main Chart component
src/react/components/chart/chart.test.tsx Test coverage for KeyFigure rendering in Chart component
src/core/types/queryVisualizationResponse.ts Type definitions for KeyFigure visualization and showUnit setting
src/core/tables/htmlTable.ts HTML rendering logic for key figure display
src/core/tables/htmlTable.test.ts Tests for key figure HTML rendering functionality
src/core/styles/chart.css CSS styles for key figure components
sonar-project.properties Updated exclusions to include testFixtures directory

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants