-
Notifications
You must be signed in to change notification settings - Fork 0
KeyFigure visualization type #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
774616c to
22ca73e
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new KeyFigure visualization type for displaying single statistical values in a card-like format. The implementation includes React components, styling, and HTML rendering capabilities specifically designed for key figure displays.
- Adds KeyFigure as a new visualization type alongside existing charts and tables
- Implements React component and HTML rendering for key figure display with styling support
- Includes comprehensive test coverage and Storybook stories for the new feature
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/stories/tablestories/keyfigure.stories.tsx | Storybook stories demonstrating basic and custom-styled key figure components |
| src/react/components/globalStyle/globalStyle.ts | Global CSS styles for key figure elements |
| src/react/components/chart/keyFigureView.tsx | React component for rendering key figure visualizations |
| src/react/components/chart/keyFigureView.test.tsx | Unit tests for the KeyFigureView component |
| src/react/components/chart/chart.tsx | Integration of KeyFigure type into main Chart component |
| src/react/components/chart/chart.test.tsx | Test coverage for KeyFigure rendering in Chart component |
| src/core/types/queryVisualizationResponse.ts | Type definitions for KeyFigure visualization and showUnit setting |
| src/core/tables/htmlTable.ts | HTML rendering logic for key figure display |
| src/core/tables/htmlTable.test.ts | Tests for key figure HTML rendering functionality |
| src/core/styles/chart.css | CSS styles for key figure components |
| sonar-project.properties | Updated exclusions to include testFixtures directory |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.



No description provided.