Application insights fixes #142
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull request overview
This PR refactors Application Insights configuration to use ASP.NET Core's native logging pipeline instead of NLog integration. The main changes align Application Insights with standard configuration patterns and improve its configurability.
Key Changes:
- Moved Application Insights from NLog to ASP.NET Core logging pipeline with dedicated configuration section
- Changed environment variable from
PXGRAF_APPLICATIONINSIGHTS_CONNECTION_STRINGto standardAPPLICATIONINSIGHTS_CONNECTION_STRING - Added configurable minimum log level and adaptive sampling options
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/README.md | Updated documentation to reflect new ApplicationInsights configuration section |
| docs/PRODUCTION_SETUP.md | Updated environment variable name and added configuration examples |
| docs/LOCAL_SETUP.md | Updated setup instructions with new configuration path and options |
| UnitTests/ConfigurationTests/ConfigurationTests.cs | Added tests for Application Insights configuration loading |
| UnitTests/ConfigurationTests/ApplicationInsightsConfigTests.cs | New comprehensive test suite for ApplicationInsightsConfig class |
| PxGraf/nlog.config | Removed Application Insights NLog target and rules |
| PxGraf/appsettings.template.json | Updated configuration structure for Application Insights |
| PxGraf/appsettings.deploy.json | Added Application Insights configuration section |
| PxGraf/Startup.cs | Refactored Application Insights setup to use new configuration |
| PxGraf/Settings/Configuration.cs | Updated to use ApplicationInsightsConfig class |
| PxGraf/Settings/ApplicationInsightsConfig.cs | New configuration class for Application Insights |
| PxGraf/PxGraf.csproj | Version bump to 4.5.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are virtually identical to this PxApi PR: StatisticsFinland/PxApi#43