feat: build Ubuntu arm64 #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiuxiuxar
force-pushed
the
feat/ubuntu-arm
branch
from
350879a to
1e9920d
Compare
xiuxiuxar
force-pushed
the
feat/ubuntu-arm
branch
from
1e9920d to
61c8791
Compare
8ball030
requested changes
Jun 9, 2025
.github/workflows/publish.yaml
Outdated
| --tag $IMAGE_NAME:${RELEASE_VERSION} \ | ||
| --tag $IMAGE_NAME:latest \ | ||
| --tag $IMAGE_NAME:${RELEASE_VERSION}-${{ matrix.tag_suffix }} \ | ||
| --tag $IMAGE_NAME:latest-${{ matrix.tag_suffix }} \ |
Contributor
There was a problem hiding this comment.
We kind of need the image name to be latest still, otherwise down stream will not be able to pull latest
Were you able to execute this locally?
8ball030
reviewed
Jun 11, 2025
| args: '' | ||
| - platform: 'windows-latest' | ||
| args: '' | ||
| docker_platform: 'windows/amd64' # adjust based on your image build support |
| paradigm-flood = "^0.3.1" | ||
| lxml = {extras = ["html-clean"], version = "^5.3.1"} | ||
| aioprometheus = "^23.12.0" | ||
| connectorx = "^0.4.3" |
Contributor
|
@xiuxiuxar can you add in the arm check? But i think other than that this is good to go to see if ti releases. |
8ball030
reviewed
Jun 11, 2025
Contributor
8ball030
left a comment
8ball030
left a comment
There was a problem hiding this comment.
Interesting lets see what happens, thanks alot for the pr!
8ball030
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.