audit:feedback-3 #38
Merged
audit:feedback-3 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8ball030
commented
Jul 14, 2025
|
|
||
| /// @dev gets allocated Incentives | ||
| /// @return allocatedRewards Allocated rewards. | ||
| function getAllocatedIncentives() external view returns (uint256 allocatedRewards) { |
Contributor
Author
There was a problem hiding this comment.
so sexy to be able to instansiate vars like this
77ph
reviewed
Jul 15, 2025
src/DerolasAuction.sol
Outdated
| require(msg.sender == owner, "Unauthorized account"); | ||
| uint256 incentiveBalance = IToken(incentiveTokenAddress).balanceOf(address(this)); | ||
| uint256 incentiveBalance = IToken(incentiveTokenAddress).balanceOf(address(this)) - allocatedRewards; | ||
| require(incentiveBalance > 0, "No incentive token balance to withdraw"); |
Collaborator
There was a problem hiding this comment.
if in line
incentiveBalance = IToken(incentiveTokenAddress).balanceOf(address(this)) - allocatedRewards;
IToken(incentiveTokenAddress).balanceOf(address(this)) < allocatedRewards
u not calculate negative number, but "arithmetic revert"
require(incentiveBalance > 0, "No incentive token balance to withdraw"); - not needed, anyway uint can't be negative
8ball030
commented
Jul 18, 2025
| require(msg.sender == owner, "Unauthorized account"); | ||
| uint256 incentiveBalance = IToken(incentiveTokenAddress).balanceOf(address(this)) - allocatedRewards; | ||
| require(incentiveBalance > 0, "No incentive token balance to withdraw"); | ||
| if (incentiveBalance == 0) revert NoAvailableIncentiveBalance(); |
Contributor
Author
There was a problem hiding this comment.
Necessary as no need to emit events if 0.
negative case is covered by the language itself which will revert.
77ph
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.