Set defaults and improve region naming in loaders #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sets defaults for qc_method, pip_cutoff_to_skip_ind and pip_cutoff_to_skip_sumstat when multiple contexts are used, and regions when only region_name_col is passed or nothing is passed.
Changes
Rationale
Removes the need to always pass verbose arguments for common cases, sets defaults to match was is stated in the docs.
Region names are needed for colocboost_analysis_pipeline to run without errors if multiple regions per phenotype file are analyzed. Previously, names were only assigned if BOTH region_name_col and extract_region_name were passed. This meant in practice you could not pass phenotype files with multiple phenotypes within the region without also passing both these parameters.
Testing