Skip to content

Conversation

@danielnachun
Copy link
Collaborator

Using profvis to check the computational time for each part of functions. Improve on several way:

  1. check_pair_jkeach: instead of checking every pair, we check the upper tri first to reduce the burden.
  2. Still some LD checking issue caused the LD-free mode.
  3. change matrix multiplication using tcrossprod function

xueweic and others added 14 commits September 12, 2025 20:58
Using profvis to check the computational time for each part of functions. Improve on several way:
1. check_pair_jkeach: instead of checking every pair, we check the upper tri first to reduce the burden.
2. Still some LD checking issue caused the LD-free mode.
3. change matrix multiplication using tcrossprod function
The highlighting feature has been updated to provide greater flexibility in visualization options. In previous versions, additional highlight variables in the colocboost plot could only be displayed as vertical lines by setting add_vertical = TRUE.
The updated colocboost_plot function now offers more versatile highlighting capabilities through the new add_highlight = TRUE parameter, which allows users to display highlight variables as either vertical lines or red star markers, providing improved customization for data visualization needs.
To enhance computational efficiency, we pre-calculate LD values for each pair of outcome-specific best parameter updates at each boost update.
For the merged CoS, we recalibrate the CoS variants based on the merged weight. We should recalculate purity for the merged CoS and filter unpured merged CoS.
fix error when focal outcome does not pass multiple testing correction at the first place.
fix bug for choosing top variable in ucos details
fix fine-mapping one iteration issue
Comment out to avoid running this code here, as we do not have real data files in examples
handle duplication variables - remove one of them
@danielnachun danielnachun changed the title improve computational Re-try PR Nov 4, 2025
@xueweic xueweic closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants