feature [SGW-904] add params on post requests in L1 api#29
Merged
juanolmedo1 merged 3 commits intomainfrom Aug 27, 2025
Merged
Conversation
juandavidkincaid
requested changes
Aug 27, 2025
| @@ -1,4 +1,4 @@ | |||
| import { RestApi } from "@stardust-collective/dag4-core"; | |||
| import { RestApi, RestApiOptions } from "@stardust-collective/dag4-core"; | |||
Member
There was a problem hiding this comment.
Is there any reason why we need to include RestApiOptions instead of just params?
Contributor
Author
There was a problem hiding this comment.
Not for now. I added the options param just for flexibility, we may need it in the future and the RestApi class supports it. I though it was a good opportunity to expose all supported params.
juandavidkincaid
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SGW-904
Changes
paramsandoptionsas optional fields in the following methods:dag-accountandmetagraph-token-client