Skip to content

feat [CE-792] adds limit, search_after and search_before params on BE endpoints#26

Merged
juanolmedo1 merged 11 commits intomainfrom
development/juan-o/CE-792/limit-param-on-be-endpoints
Jul 14, 2025
Merged

feat [CE-792] adds limit, search_after and search_before params on BE endpoints#26
juanolmedo1 merged 11 commits intomainfrom
development/juan-o/CE-792/limit-param-on-be-endpoints

Conversation

@juanolmedo1
Copy link
Contributor

@juanolmedo1 juanolmedo1 commented Jul 10, 2025

CE-792

Changes

  • Added support to the next param in all BE API list methods
  • Set default value null on all params (limit, next, search_after and search_before).
  • List endpoints related to rewards supports only limit and next params (search after and search before are not supported by the API)
  • Refactored old _getTransactionSearchPathAndParams with new private method buildRequestParams: receives an object instead of multiple params.
  • Removed unused _formatDate function.
  • sentOnly /sent and receivedOnly /received are handled in the calling function

Copy link
Member

@juandavidkincaid juandavidkincaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't there any other places in which those parameters exists? or should exist? only on the BlockExplorerV2Api?

Copy link
Member

@juandavidkincaid juandavidkincaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old snapshots might not contain all new/recent fields, update types to reflect this. Besides that everything else looks fine.

@juanolmedo1 juanolmedo1 merged commit 7886f71 into main Jul 14, 2025
1 check passed
@juanolmedo1 juanolmedo1 deleted the development/juan-o/CE-792/limit-param-on-be-endpoints branch July 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants