Identifying compositions by handler URI

[PatrykSzwer]

Related issue: https://github.com/Starcounter/Blending/issues/422#issuecomment-451958858 p.2

[PatrykSzwer]

I included your requested changes and tested this out with the old and new blending app. Please re-review.

[warpech]

There are 7 failing WCT tests with the following message:

Error: Cannot read property 'filter' of undefined
                                 <unknown> at /components/starcounter-include/starcounter-include.html:346
  HTMLElement.StarcounterIncludePrototype._renderCompositionChange at /components/starcounter-include/starcounter-include.html:274
  HTMLElement.StarcounterIncludePrototype.updateComposition at /components/starcounter-include/starcounter-include.html:342
                           HTMLElement.set at /components/starcounter-include/starcounter-include.html:105
                       Context.<anonymous> at cleanup_removed_partial_Layout.html:41

To reproduce locally, follow the instruction from https://github.com/Starcounter/starcounter-include/blob/master/CONTRIBUTING.md#developing-the-element

The problem comes from the line that begins with const defaultViewHtmlsToBeRendered = compositionProvider.ActualViewUris.filter. It comes from the fact that we removed this if: https://github.com/Starcounter/starcounter-include/blob/master/starcounter-include.html#L315. Some tests only check the legacy JSON structure and do not contain ViewUris nor ActualViewUris. Can you please add ViewUris nor ActualViewUris to the fixtures of the failing tests? Then the tests should pass.

[tomalec]

Can you add a test for the path that contain BlendingUri?

[warpech]

Today is @PatrykSzwer's last day, so he wont add anything but I may.

Can you add a test for the path that contain BlendingUri?

This whole section never had a single test. This PR does not make it much worse, but I agree tests should be added.

starcounter-include/starcounter-include.html

Lines 315 to 339 in e7a9b1e

	const defaultViewHtmlsToBeRendered =
	compositionProvider.ActualViewUris.filter(
	x => !compositionProvider.ViewUris.includes(x.hasOwnProperty("BlendingUri") ? x.BlendingUri : x))
	.map(x => x.hasOwnProperty("ViewHtml") ? x.ViewHtml : x);
	const keys = Object.keys(this.viewModel);
	for (let key of keys) {
	const scoped = this.viewModel[key];
	if (scoped && scoped.Html && defaultViewHtmlsToBeRendered.includes(scoped.Html)) {
	if (this.defaultComposition) {
	this.template.scopedNodes.forEach((nodes) => {
	if (nodes.scope === key) {
	nodes.forEach((node) => appendComposition(customComposition, node));
	}
	});
	}
	else {
	// BUG,TODO (tomalec): looks like a bug
	// This means that if there *is* a custom composition, but it does not cover all views,
	// and it happend that none of the views had a default composition,
	// we would discard custom composition and use default -> fallback
	return false;
	}
	}
	}