Open
Conversation
added 6 commits
September 11, 2025 16:24
add test fix include macro call argument for arg more than 1
889b9b3 to
8d25837
Compare
09a066b to
1ce9df0
Compare
1ce9df0 to
8c80357
Compare
add par stage general theory
added 3 commits
October 20, 2025 14:03
| // type IteratorType = Either< | ||
| // Chain< | ||
| // std::iter::Flatten<std::option::IntoIter<Ind1::IteratorType>>, | ||
| // std::iter::Flatten<std::option::IntoIter<Ind2::IteratorType>>, |
There was a problem hiding this comment.
Bug: Index Combination Fails to Chain Results
The RelIndexCombined::iter_all implementation doesn't correctly combine results from both underlying indices. It returns either the first iterator (if not empty) or the second (if the first is empty), but never chains them. This means the second index's items are entirely ignored when the first index has any.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Introduce a new Slog DSL compiled via proc-macros to Ascent, add heuristic join reordering and macro enhancements (ascent_source captures, delta/total), plus docs, examples, and tests.
slog,slog_utils,slog_theory, andslog_testcrates implementing a Slog language that compiles to Ascent via proc-macros; includes utilities (ID calc, helpers), theory support (equality), and tests.#[heuristic_reordering]and MIR/HIR plumbing (join strategy parsing, var usage analysis, rule reordering, index reselection, updated IR/MIR data).ascent_source!to support captured arguments andinclude_source!(path, caps…).delta!andtotal!; add optional#![custom_return_conditions]andrun_customizedpath.#![allow_non_stratified_agg].ascent_heuristic_order.rs, updatedascent_source.rs, minor list example formatting).slog*) and dependencies.Written by Cursor Bugbot for commit 148ff76. This will update automatically on new commits. Configure here.