Added -check flag to compile commands#167
Draft
m-hilgendorf wants to merge 1 commit intoStanzaOrg:masterfrom
Draft
Added -check flag to compile commands#167m-hilgendorf wants to merge 1 commit intoStanzaOrg:masterfrom
m-hilgendorf wants to merge 1 commit intoStanzaOrg:masterfrom
Conversation
m-hilgendorf
commented
Aug 3, 2022
Comment on lines
+21
to
+24
| 4) We are compiling in unoptimized mode and are running "check" | ||
|
|
||
| 5) We are compiling in optimized mode and are running "check" | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These two cases seem to be equivalent.
m-hilgendorf
commented
Aug 3, 2022
|
|
||
| ;Save optimized packages if necessary | ||
| if pkg-dir is String and optimize? : | ||
| if pkg-dir is String and optimize? and (not check?) : |
Contributor
Author
There was a problem hiding this comment.
If we're checking, we don't want to write any additional output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.