Skip to content

Conversation

@lukaskollmer
Copy link
Member

fix comorbidities; adjust SK fetching

⚙️ Release Notes

  • adds a primary comorbidity option
  • removes leftover debug UI from the comorbidity start time picker
  • reduces the SensorKit concurrency level from 6 parallel sensors to 4

✅ Testing

n/a

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.97%. Comparing base (75dba30) to head (6669636).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         187      187           
  Lines        2507     2507           
=======================================
  Hits         1729     1729           
  Misses        778      778           
Files with missing lines Coverage Δ
MyHeartCounts/Account/AccountSheet.swift 76.00% <ø> (ø)
...artCounts/Account/Demographics/Comorbidities.swift 75.00% <ø> (ø)
...nts/Account/Demographics/ComorbiditiesPicker.swift 80.96% <ø> (ø)
... Import/HistoricalHealthSamplesExportManager.swift 55.56% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dba30...6669636. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you @lukaskollmer 🚀

Copy link
Contributor

@PaulGoldschmidt PaulGoldschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukaskollmer! Happy to see this merged; would then include the changes in the respective firebase PR.

@lukaskollmer lukaskollmer moved this from Todo to In Progress in MyHeart Counts Project Planning Dec 21, 2025
@lukaskollmer lukaskollmer merged commit ec2f41e into main Dec 23, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in MyHeart Counts Project Planning Dec 23, 2025
@lukaskollmer lukaskollmer deleted the lukas/fix-comorbidities branch December 23, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

4 participants