Set secure cookie flag properly with WebAuthSSLReturn#6
Open
rra wants to merge 2 commits intoStanford:masterfrom
Open
Set secure cookie flag properly with WebAuthSSLReturn#6rra wants to merge 2 commits intoStanford:masterfrom
rra wants to merge 2 commits intoStanford:masterfrom
Conversation
If WebAuthSSLReturn is set to true, we may see non-SSL connections that are SSL from the perspective of the browser (such as a WebAuth server behind an L7 load balancer that does SSL termination). In this case, we still want to set the secure flag on the cookie so that the browser properly restricts it to SSL connections. Trigger setting the secure flag off the combination of whether the request is SSL and whether WebAuthSSLReturn is set, rather than just the former.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If WebAuthSSLReturn is set to true, we may see non-SSL connections
that are SSL from the perspective of the browser (such as a WebAuth
server behind an L7 load balancer that does SSL termination). In
this case, we still want to set the secure flag on the cookie so that
the browser properly restricts it to SSL connections.
Trigger setting the secure flag off the combination of whether the
request is SSL and whether WebAuthSSLReturn is set, rather than
just the former.