[WIP] Configure RCON for active player monitoring#52
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to Fix RCON Configuration Issue
Problem
Users who enable RCON and enter credentials still see the message "RCON is not enabled or configured" even when RCON is properly configured. The root cause is that the RCON library (
nizarii/arma-rcon-class) is not installed, but the error message doesn't distinguish between "RCON not configured" and "RCON library not installed".Root Cause
In
rcon_manager.php, theisEnabled()method returnsfalsewhen$this->libraryAvailableisfalse, which happens when the Composer packagenizarii/arma-rcon-classis not installed. The current error message is misleading.Minimal Changes Required
active_players.phpto show a more specific error message when RCON is configured but the library is missingrcon_manager.phpto add a method that distinguishes between "not configured" and "library missing"Files to Modify
rcon_manager.php- Add helper method to check library availability separatelyactive_players.php- Update error message display logicadmin.php- Add warning about missing library (optional)Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.