Skip to content

fix: removed lock file #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ninerian merged 4 commits into from
Jan 22, 2025
Merged

fix: removed lock file #87

Ninerian merged 4 commits into from
Jan 22, 2025

Conversation

@Ninerian
Copy link
Contributor

@Ninerian Ninerian commented Jan 13, 2025

What have I done

  • deleted the lock file

Why did you do it

  • we had good experiences with this in the create widget repository
  • it also helps with internal dependencies not resolvable for customers

How to test it

  • create a plugin and install the dependencies
  • run the tests to see if they succeed

@Ninerian Ninerian requested a review from maximizeIT as a code owner January 13, 2025 09:56
@Ninerian
Copy link
Contributor Author

Ninerian commented Jan 13, 2025

Auto Approve @maximizeIT ? ;-)

@maximizeIT
Copy link
Contributor

maximizeIT commented Jan 15, 2025

Auto Approve @maximizeIT ? ;-)

Still done manually 😄

@Ninerian Ninerian merged commit 0716dd5 into master Jan 22, 2025
5 checks passed
@Ninerian Ninerian deleted the NFS-remove-lock-file branch January 22, 2025 09:46
@maximizeIT maximizeIT mentioned this pull request Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximizeIT maximizeIT maximizeIT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ninerian @maximizeIT