chore(nix): use mkShellNoCC for lighter dev shell#286
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR optimizes the Nix development shell by switching from mkShell to mkShellNoCC, removing unnecessary C compiler toolchain dependencies for a Node.js/TypeScript SDK project. This change reduces dependencies and improves shell initialization speed.
Changes:
- Replaced
mkShellwithmkShellNoCCin flake.nix - Updated flake.lock with latest versions of flake-parts and nixpkgs inputs
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flake.nix | Changed devShell from mkShell to mkShellNoCC to eliminate unnecessary C compiler dependencies |
| flake.lock | Updated flake-parts and nixpkgs to their latest versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Switch from mkShell to mkShellNoCC since this project doesn't require a C compiler toolchain. This reduces unnecessary dependencies and speeds up shell initialisation for Node.js/pnpm development.
ryoppippi
force-pushed
the
chore/use-mkshellnocc
branch
from
4fb5421 to
6b1c7d3
Compare
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from
mkShelltomkShellNoCCsince this project doesn't require a C compiler toolchain. This reduces unnecessary dependencies and speeds up shell initialisation for Node.js/pnpm development.Also updates flake.lock to latest inputs.
Summary by cubic
Use mkShellNoCC for the Nix dev shell to remove the C toolchain. This cuts unnecessary dependencies and speeds up shell startup for Node.js/pnpm.
Written for commit 6b1c7d3. Summary will update on new commits.