Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the direnv setup instructions from the Nix Flake development environment documentation in the README. However, the change is incomplete.
- Removes the command to create
.envrcfile - Removes the comment explaining direnv usage
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Or use direnv for automatic activation | ||
| echo "use flake" > .envrc | ||
| direnv allow |
There was a problem hiding this comment.
The removal of the direnv setup instructions leaves an orphaned direnv allow command with no context. This command won't work without the .envrc file setup that was just removed. Either restore the removed lines to keep the complete direnv instructions, or remove line 609 entirely if direnv support is no longer documented.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes configuration and documentation issues.
Changes
This aligns with fixes applied to the Python SDK (stackone-ai-python#74).