Skip to content

fix: Revert "fix(ci): revert changes 2.0.5 ~ 2.0.7"#249

Merged
ryoppippi merged 1 commit intomainfrom
revert-246-revert-ci-changes
Dec 16, 2025
Merged

fix: Revert "fix(ci): revert changes 2.0.5 ~ 2.0.7"#249
ryoppippi merged 1 commit intomainfrom
revert-246-revert-ci-changes

Conversation

@ryoppippi
Copy link
Copy Markdown
Contributor

@ryoppippi ryoppippi commented Dec 15, 2025

Reverts #246


Summary by cubic

Restores the release workflow to pack the package and publish the built .tgz via npm for more reliable releases. Also adds Node.js 24 to the Nix dev shell and removes the pnpm-only preinstall guard.

  • Refactors
    • Pack with pnpm and publish the tarball with npm in the release job.
    • Add nodejs_24 to the Nix dev shell.
    • Remove the "only-allow pnpm" preinstall script from package.json.

Written for commit a00dd2f. Summary will update automatically on new commits.

Copilot AI review requested due to automatic review settings December 15, 2025 18:29
@ryoppippi ryoppippi requested a review from a team as a code owner December 15, 2025 18:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous commit that removed the preinstall script and made CI changes. The revert restores the removal of the only-allow pnpm preinstall check, adds Node.js 24 back to the Nix development shell, and updates the release workflow to pack and publish the package using npm directly instead of pnpm.

Key Changes

  • Removes the preinstall script that enforced pnpm usage
  • Adds Node.js 24 to the Nix development environment
  • Modifies the release workflow to pack with pnpm but publish with npm

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
package.json Removes the preinstall script enforcing pnpm
flake.nix Adds nodejs_24 to development shell dependencies
.github/workflows/release.yaml Updates publish workflow to pack with pnpm and publish with npm

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +50 to +52
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
echo "Publishing package: $PACKAGE_TGZ"
npm publish "$PACKAGE_TGZ" --access public
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ls to capture filenames is fragile and can break with unexpected filenames or when no .tgz files exist. Use shell globbing with array assignment instead: PACKAGE_TGZ=(*.tgz) and then reference ${PACKAGE_TGZ[0]}.

Suggested change
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
echo "Publishing package: $PACKAGE_TGZ"
npm publish "$PACKAGE_TGZ" --access public
PACKAGE_TGZ=( *.tgz )
echo "Publishing package: ${PACKAGE_TGZ[0]}"
npm publish "${PACKAGE_TGZ[0]}" --access public

Copilot uses AI. Check for mistakes.
run: nix develop --command pnpm publish --provenance --no-git-checks --access public
shell: bash
run: |
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing error handling if no .tgz file is found. The script should verify that PACKAGE_TGZ is not empty before attempting to publish, otherwise npm publish will fail with a confusing error message.

Suggested change
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
if [ -z "$PACKAGE_TGZ" ]; then
echo "Error: No .tgz package file found to publish."
exit 1
fi

Copilot uses AI. Check for mistakes.
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/StackOneHQ/stackone-ai-node/@stackone/ai@249

commit: a00dd2f

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@ryoppippi ryoppippi marked this pull request as draft December 15, 2025 18:32
@ryoppippi ryoppippi changed the title Revert "fix(ci): revert changes 2.0.5 ~ 2.0.7" fix: Revert "fix(ci): revert changes 2.0.5 ~ 2.0.7" Dec 16, 2025
@ryoppippi ryoppippi marked this pull request as ready for review December 16, 2025 14:56
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@ryoppippi ryoppippi force-pushed the revert-246-revert-ci-changes branch from 5c682e1 to a00dd2f Compare December 16, 2025 14:58
@ryoppippi ryoppippi enabled auto-merge (squash) December 16, 2025 14:58
Copy link
Copy Markdown
Contributor

@glebedel glebedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryoppippi ryoppippi merged commit a2bb4d6 into main Dec 16, 2025
11 checks passed
@ryoppippi ryoppippi deleted the revert-246-revert-ci-changes branch December 16, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants