Skip to content

fix(ci): revert changes 2.0.5 ~ 2.0.7 #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 2 commits into from
Dec 15, 2025
Merged

fix(ci): revert changes 2.0.5 ~ 2.0.7 #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cdaef1
Revert "fix(ci): pack (#244)"
ryoppippi Dec 15, 2025
e655535
Revert "fix(ci): remove --provenance (#242)"
ryoppippi Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,5 @@ jobs:
registry-url: 'https://registry.npmjs.org'
node-version: lts/*

- name: 📦 Pack package
run: nix develop --command pnpm pack

- name: 🚀 Publish package
shell: bash
run: |
PACKAGE_TGZ=$(ls *.tgz | head -n 1)
echo "Publishing package: $PACKAGE_TGZ"
npm publish "$PACKAGE_TGZ" --access public
run: nix develop --command pnpm publish --provenance --no-git-checks --access public
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --no-git-checks flag bypasses important safety checks that verify the working directory is clean and the git tag matches the package version. This could lead to publishing packages with uncommitted changes or version mismatches. Consider removing this flag unless there is a specific reason to bypass these validations.

Suggested change
run: nix develop --command pnpm publish --provenance --no-git-checks --access public
run: nix develop --command pnpm publish --provenance --access public

Copilot uses AI. Check for mistakes.
1 change: 0 additions & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
devShells.default = pkgs.mkShell {
buildInputs = with pkgs; [
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing nodejs_24 from buildInputs while keeping pnpm_10 may cause issues, as pnpm requires Node.js to function. Either Node.js should be included explicitly or pnpm_10 should provide it as a dependency. Verify that pnpm_10 includes Node.js or re-add nodejs to the buildInputs.

Suggested change
buildInputs = with pkgs; [
buildInputs = with pkgs; [
nodejs_24

Copilot uses AI. Check for mistakes.
pnpm_10
nodejs_24
];

shellHook = ''
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
"lint:oxfmt": "oxfmt --no-error-on-unmatched-pattern --check .",
"lint:oxlint": "oxlint --max-warnings=0 --type-aware --type-check",
"lint:knip": "knip",
"preinstall": "npx only-allow pnpm",
"prepack": "npm pkg delete scripts.preinstall && pnpm run build",
"test": "vitest",
"coverage": "vitest run --coverage"
Expand Down
Loading