Skip to content

fix(ci): move install to nix action#240

Merged
ryoppippi merged 1 commit intomainfrom
fix-ci-
Dec 15, 2025
Merged

fix(ci): move install to nix action#240
ryoppippi merged 1 commit intomainfrom
fix-ci-

Conversation

@ryoppippi
Copy link
Copy Markdown
Contributor

@ryoppippi ryoppippi commented Dec 15, 2025

Summary by cubic

Centralize Nix environment setup in the shared setup-nix action and remove redundant init/install steps from CI, dry-publish, and release. This reduces duplication and streamlines builds.

  • Refactors
    • setup-nix: load the Nix dev environment (nix develop --command true).
    • ci.yaml: remove explicit Nix init step.
    • dry-publish.yaml: remove pnpm install; run via nix develop.
    • release.yaml: remove pnpm install; run via nix develop.

Written for commit a9ce5b8. Summary will update automatically on new commits.

@ryoppippi ryoppippi requested a review from a team as a code owner December 15, 2025 16:29
Copilot AI review requested due to automatic review settings December 15, 2025 16:29
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

npm i https://pkg.pr.new/StackOneHQ/stackone-ai-node/@stackone/ai@240

commit: a9ce5b8

@ryoppippi ryoppippi enabled auto-merge (squash) December 15, 2025 16:32
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@ryoppippi ryoppippi merged commit fe729aa into main Dec 15, 2025
13 checks passed
@ryoppippi ryoppippi deleted the fix-ci- branch December 15, 2025 16:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors CI/CD workflows by consolidating Nix environment initialization into a reusable setup-nix action. The change leverages the shellHook in flake.nix which automatically installs pnpm dependencies when the Nix development environment is loaded, eliminating the need for explicit pnpm install steps in individual workflows.

Key changes:

  • Centralized Nix environment initialization in the setup-nix composite action
  • Removed redundant pnpm install --frozen-lockfile steps from workflow files
  • Removed duplicate nix develop --command true initialization from CI workflow

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/actions/setup-nix/action.yaml Added Nix development environment initialization step that triggers the shellHook to install dependencies
.github/workflows/release.yaml Removed redundant explicit dependency installation step
.github/workflows/dry-publish.yaml Removed redundant explicit dependency installation step
.github/workflows/ci.yaml Removed redundant Nix environment initialization step (now handled by setup-nix action)

The changes are architecturally sound and improve maintainability by centralizing environment setup logic. No issues were identified in the implementation.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants